Re: [PR] Core, Flink, Spark: Verify maintenance actions with DVs [iceberg]

manuzhang commented on PR #11485: URL: https://github.com/apache/iceberg/pull/11485#issuecomment-2485137930 @nastra Can we link this PR to #11122? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Core, Flink, Spark: Verify maintenance actions with DVs [iceberg]

aokolnychyi commented on code in PR #11485: URL: https://github.com/apache/iceberg/pull/11485#discussion_r1840256285 ## core/src/main/java/org/apache/iceberg/BaseContentScanTask.java: ## @@ -82,7 +83,7 @@ public long start() { @Override public long length() { -return

Re: [PR] Core, Flink, Spark: Verify maintenance actions with DVs [iceberg]

nastra commented on code in PR #11485: URL: https://github.com/apache/iceberg/pull/11485#discussion_r1840633435 ## core/src/test/java/org/apache/iceberg/TestMetadataTableFilters.java: ## @@ -447,6 +441,12 @@ public void testPartitionSpecEvolutionRemovalV2() { assertThat(tas

Re: [PR] Core, Flink, Spark: Verify maintenance actions with DVs [iceberg]

nastra merged PR #11485: URL: https://github.com/apache/iceberg/pull/11485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Core, Flink, Spark: Verify maintenance actions with DVs [iceberg]

nastra commented on PR #11485: URL: https://github.com/apache/iceberg/pull/11485#issuecomment-2473986516 thanks @aokolnychyi for the review. I'll address your comment in the next PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] Core, Flink, Spark: Verify maintenance actions with DVs [iceberg]

aokolnychyi commented on code in PR #11485: URL: https://github.com/apache/iceberg/pull/11485#discussion_r1840262214 ## core/src/test/java/org/apache/iceberg/TestMetadataTableFilters.java: ## @@ -447,6 +441,12 @@ public void testPartitionSpecEvolutionRemovalV2() { assertTha

Re: [PR] Core, Flink, Spark: Verify maintenance actions with DVs [iceberg]

aokolnychyi commented on code in PR #11485: URL: https://github.com/apache/iceberg/pull/11485#discussion_r1840251039 ## core/src/main/java/org/apache/iceberg/BaseFileScanTask.java: ## @@ -176,6 +176,8 @@ public boolean canMerge(ScanTask other) { @Override public SplitS

Re: [PR] Core, Flink, Spark: Verify maintenance actions with DVs [iceberg]

nastra commented on code in PR #11485: URL: https://github.com/apache/iceberg/pull/11485#discussion_r1837611245 ## core/src/main/java/org/apache/iceberg/BaseContentScanTask.java: ## @@ -82,7 +83,7 @@ public long start() { @Override public long length() { -return file

Re: [PR] Core, Flink, Spark: Verify maintenance actions with DVs [iceberg]

nastra commented on code in PR #11485: URL: https://github.com/apache/iceberg/pull/11485#discussion_r1837607694 ## core/src/main/java/org/apache/iceberg/BaseFileScanTask.java: ## @@ -176,7 +176,7 @@ public boolean canMerge(ScanTask other) { @Override public SplitScanTa

Re: [PR] Core, Flink, Spark: Verify maintenance actions with DVs [iceberg]

nastra commented on code in PR #11485: URL: https://github.com/apache/iceberg/pull/11485#discussion_r1837593058 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction3.java: ## @@ -21,38 +21,37 @@ import static org.assertj.core.api.Assert

Re: [PR] Core, Flink, Spark: Verify maintenance actions with DVs [iceberg]

aokolnychyi commented on code in PR #11485: URL: https://github.com/apache/iceberg/pull/11485#discussion_r1837135723 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction3.java: ## @@ -21,38 +21,37 @@ import static org.assertj.core.api.A

Re: [PR] Core, Flink, Spark: Verify maintenance actions with DVs [iceberg]

aokolnychyi commented on code in PR #11485: URL: https://github.com/apache/iceberg/pull/11485#discussion_r1837132399 ## core/src/main/java/org/apache/iceberg/BaseFileScanTask.java: ## @@ -176,7 +176,7 @@ public boolean canMerge(ScanTask other) { @Override public SplitS

Re: [PR] Core, Flink, Spark: Verify maintenance actions with DVs [iceberg]

aokolnychyi commented on code in PR #11485: URL: https://github.com/apache/iceberg/pull/11485#discussion_r1837132399 ## core/src/main/java/org/apache/iceberg/BaseFileScanTask.java: ## @@ -176,7 +176,7 @@ public boolean canMerge(ScanTask other) { @Override public SplitS

Re: [PR] Core, Flink, Spark: Verify maintenance actions with DVs [iceberg]

aokolnychyi commented on code in PR #11485: URL: https://github.com/apache/iceberg/pull/11485#discussion_r1837123187 ## core/src/main/java/org/apache/iceberg/BaseContentScanTask.java: ## @@ -82,7 +83,7 @@ public long start() { @Override public long length() { -return

Re: [PR] Core, Flink, Spark: Verify maintenance actions with DVs [iceberg]

aokolnychyi commented on code in PR #11485: URL: https://github.com/apache/iceberg/pull/11485#discussion_r1837123187 ## core/src/main/java/org/apache/iceberg/BaseContentScanTask.java: ## @@ -82,7 +83,7 @@ public long start() { @Override public long length() { -return

Re: [PR] Core, Flink, Spark: Verify maintenance actions with DVs [iceberg]

aokolnychyi commented on PR #11485: URL: https://github.com/apache/iceberg/pull/11485#issuecomment-2468290759 This work is also part of #11122. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the