aokolnychyi commented on code in PR #11485:
URL: https://github.com/apache/iceberg/pull/11485#discussion_r1837132399
##########
core/src/main/java/org/apache/iceberg/BaseFileScanTask.java:
##########
@@ -176,7 +176,7 @@ public boolean canMerge(ScanTask other) {
@Override
public SplitScanTask merge(ScanTask other) {
SplitScanTask that = (SplitScanTask) other;
- return new SplitScanTask(offset, len + that.length(), fileScanTask,
deletesSizeBytes);
+ return new SplitScanTask(offset, len + that.length(), fileScanTask,
deletesSizeBytes());
Review Comment:
Hm, do we actually need to force the computation of the size of deletes
while merging? It seems we should keep the original logic and potentially add a
comment why we are not calling `deleteSizeBytes()`. After this change, if we
merge 4 tasks into 1, we will compute the size of deletes 4 times instead of 1
after the merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
