aokolnychyi commented on code in PR #11485:
URL: https://github.com/apache/iceberg/pull/11485#discussion_r1837123187
##########
core/src/main/java/org/apache/iceberg/BaseContentScanTask.java:
##########
@@ -82,7 +83,7 @@ public long start() {
@Override
public long length() {
- return file.fileSizeInBytes();
+ return ScanTaskUtil.contentSizeInBytes(file);
Review Comment:
This is probably correct. Is this for `PositionDeletesScanTask`? Do we need
to update `start` if we update `length`?
##########
core/src/main/java/org/apache/iceberg/BaseContentScanTask.java:
##########
@@ -82,7 +83,7 @@ public long start() {
@Override
public long length() {
- return file.fileSizeInBytes();
+ return ScanTaskUtil.contentSizeInBytes(file);
Review Comment:
This is probably correct. Is this for `PositionDeletesScanTask`?
Do we need to update `start` if we update `length`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
