Fokko commented on PR #1334:
URL: https://github.com/apache/iceberg-rust/pull/1334#issuecomment-2902740777
Thanks @kevinjqliu 🙌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
Fokko merged PR #1334:
URL: https://github.com/apache/iceberg-rust/pull/1334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko commented on code in PR #1334:
URL: https://github.com/apache/iceberg-rust/pull/1334#discussion_r2103449335
##
crates/integration_tests/testdata/spark/provision.py:
##
@@ -120,6 +120,14 @@
spark.sql("ALTER TABLE rest.default.test_promote_column ALTER COLUMN foo TYPE
bigi
kevinjqliu commented on code in PR #1334:
URL: https://github.com/apache/iceberg-rust/pull/1334#discussion_r2103446635
##
crates/integration_tests/testdata/spark/provision.py:
##
@@ -120,6 +120,14 @@
spark.sql("ALTER TABLE rest.default.test_promote_column ALTER COLUMN foo TYPE
Fokko commented on code in PR #1334:
URL: https://github.com/apache/iceberg-rust/pull/1334#discussion_r2095337317
##
crates/iceberg/src/spec/values.rs:
##
@@ -403,12 +403,26 @@ impl Datum {
}
}
PrimitiveType::Int =>
PrimitiveLiteral::I
Fokko commented on code in PR #1334:
URL: https://github.com/apache/iceberg-rust/pull/1334#discussion_r2095337317
##
crates/iceberg/src/spec/values.rs:
##
@@ -403,12 +403,26 @@ impl Datum {
}
}
PrimitiveType::Int =>
PrimitiveLiteral::I
Fokko commented on code in PR #1334:
URL: https://github.com/apache/iceberg-rust/pull/1334#discussion_r2095336503
##
crates/integration_tests/testdata/spark/provision.py:
##
@@ -114,8 +114,8 @@
spark.sql("ALTER TABLE rest.default.test_rename_column RENAME COLUMN lang TO
langua
kevinjqliu commented on code in PR #1334:
URL: https://github.com/apache/iceberg-rust/pull/1334#discussion_r2094170668
##
crates/iceberg/src/spec/values.rs:
##
@@ -403,12 +403,26 @@ impl Datum {
}
}
PrimitiveType::Int =>
PrimitiveLiter