Fokko commented on code in PR #1334:
URL: https://github.com/apache/iceberg-rust/pull/1334#discussion_r2095337317
##########
crates/iceberg/src/spec/values.rs:
##########
@@ -403,12 +403,26 @@ impl Datum {
}
}
PrimitiveType::Int =>
PrimitiveLiteral::Int(i32::from_le_bytes(bytes.try_into()?)),
- PrimitiveType::Long =>
PrimitiveLiteral::Long(i64::from_le_bytes(bytes.try_into()?)),
+ PrimitiveType::Long => {
Review Comment:
I first did only the V2 transformations for now. I've added a test for the
float and decimal case as well 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
