kevinjqliu commented on code in PR #1334:
URL: https://github.com/apache/iceberg-rust/pull/1334#discussion_r2094170668
##########
crates/iceberg/src/spec/values.rs:
##########
@@ -403,12 +403,26 @@ impl Datum {
}
}
PrimitiveType::Int =>
PrimitiveLiteral::Int(i32::from_le_bytes(bytes.try_into()?)),
- PrimitiveType::Long =>
PrimitiveLiteral::Long(i64::from_le_bytes(bytes.try_into()?)),
+ PrimitiveType::Long => {
Review Comment:
Relevant section from the spec:
https://iceberg.apache.org/spec/#schema-evolution
##########
crates/integration_tests/testdata/spark/provision.py:
##########
@@ -114,8 +114,8 @@
spark.sql("ALTER TABLE rest.default.test_rename_column RENAME COLUMN lang TO
language")
spark.sql("INSERT INTO rest.default.test_rename_column VALUES ('Java')")
-# Create a table, and do some evolution
-spark.sql("CREATE OR REPLACE TABLE rest.default.test_promote_column (foo int)
USING iceberg")
+# Create a table, and do some evolution on a partition column
+spark.sql("CREATE OR REPLACE TABLE rest.default.test_promote_column (foo int)
USING iceberg PARTITIONED BY (foo)")
Review Comment:
nit I think we should keep the original test and just create another table
for evolution on a partition column
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
