aihuaxu commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1966427898
##
core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java:
##
@@ -187,6 +187,21 @@ public Schema map(Types.MapType map, Schema keySchema,
Schema valueSchema) {
aihuaxu commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1966427898
##
core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java:
##
@@ -187,6 +187,21 @@ public Schema map(Types.MapType map, Schema keySchema,
Schema valueSchema) {
aihuaxu commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1966315547
##
core/src/main/java/org/apache/iceberg/avro/PruneColumns.java:
##
@@ -92,7 +93,8 @@ public Schema record(Schema record, List names,
List fields) {
hasCh
aihuaxu commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1966315547
##
core/src/main/java/org/apache/iceberg/avro/PruneColumns.java:
##
@@ -92,7 +93,8 @@ public Schema record(Schema record, List names,
List fields) {
hasCh
rdblue commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1966252517
##
core/src/main/java/org/apache/iceberg/avro/PruneColumns.java:
##
@@ -92,7 +93,8 @@ public Schema record(Schema record, List names,
List fields) {
hasCha
aihuaxu commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1964909576
##
core/src/main/java/org/apache/iceberg/avro/VariantLogicalType.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
XBaith commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1964705927
##
core/src/main/java/org/apache/iceberg/avro/VariantLogicalType.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
aihuaxu commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1964486203
##
core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java:
##
@@ -187,6 +187,21 @@ public Schema map(Types.MapType map, Schema keySchema,
Schema valueSchema) {
aihuaxu commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1964351443
##
core/src/main/java/org/apache/iceberg/avro/BaseWriteBuilder.java:
##
@@ -64,6 +64,11 @@ public ValueWriter map(Schema map, ValueWriter
valueWriter) {
return
XBaith commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1963050300
##
core/src/main/java/org/apache/iceberg/avro/VariantLogicalType.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
XBaith commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1955779484
##
core/src/main/java/org/apache/iceberg/avro/BuildAvroProjection.java:
##
@@ -265,6 +265,11 @@ public Schema map(Schema map, Supplier value) {
}
}
+ @Overr
rdblue commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1955086053
##
core/src/main/java/org/apache/iceberg/avro/AvroCustomOrderSchemaVisitor.java:
##
@@ -37,6 +37,10 @@ public static T visit(Schema schema,
AvroCustomOrderSchemaVisi
rdblue commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1955080951
##
core/src/test/java/org/apache/iceberg/avro/TestSchemaConversions.java:
##
@@ -76,7 +78,8 @@ public void testPrimitiveTypes() {
Schema.createFixed("fixe
rdblue commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1955075860
##
core/src/test/java/org/apache/iceberg/avro/TestSchemaConversions.java:
##
@@ -76,7 +78,8 @@ public void testPrimitiveTypes() {
Schema.createFixed("fixe
rdblue commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1955075130
##
core/src/test/java/org/apache/iceberg/avro/TestAvroSchemaProjection.java:
##
@@ -150,4 +150,58 @@ public void projectWithMapSchemaChanged() {
.as("Result o
rdblue commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1955061076
##
core/src/test/java/org/apache/iceberg/avro/TestAvroSchemaProjection.java:
##
@@ -150,4 +150,58 @@ public void projectWithMapSchemaChanged() {
.as("Result o
rdblue commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1955059718
##
core/src/test/java/org/apache/iceberg/avro/TestAvroSchemaProjection.java:
##
@@ -150,4 +150,58 @@ public void projectWithMapSchemaChanged() {
.as("Result o
rdblue commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1955058185
##
core/src/test/java/org/apache/iceberg/avro/TestAvroSchemaProjection.java:
##
@@ -150,4 +150,58 @@ public void projectWithMapSchemaChanged() {
.as("Result o
rdblue commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1955053312
##
core/src/main/java/org/apache/iceberg/avro/Variant.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
rdblue commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1955051131
##
core/src/main/java/org/apache/iceberg/avro/AvroSchemaUtil.java:
##
@@ -219,6 +219,13 @@ public static boolean isKeyValueSchema(Schema schema) {
return schema.g
rdblue commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1955046563
##
core/src/main/java/org/apache/iceberg/avro/Variant.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
21 matches
Mail list logo
