rdblue commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1955086053
##########
core/src/main/java/org/apache/iceberg/avro/AvroCustomOrderSchemaVisitor.java:
##########
@@ -37,6 +37,10 @@ public static <T, F> T visit(Schema schema,
AvroCustomOrderSchemaVisitor<T, F> v
visitor.recordLevels.push(name);
+ if (schema.getLogicalType() instanceof Variant) {
+ return visitor.variant(schema);
Review Comment:
Similar to my comment on `AvroSchemaVisitor`, I think this should visit the
`metadata` and `value` children.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
