Re: [PR] Add `all_manifests` metadata table with tests [iceberg-python]

kevinjqliu commented on PR #1241: URL: https://github.com/apache/iceberg-python/pull/1241#issuecomment-2584976662 Thanks for the contribution @soumya-ghosh ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Add `all_manifests` metadata table with tests [iceberg-python]

kevinjqliu merged PR #1241: URL: https://github.com/apache/iceberg-python/pull/1241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] Add `all_manifests` metadata table with tests [iceberg-python]

soumya-ghosh commented on PR #1241: URL: https://github.com/apache/iceberg-python/pull/1241#issuecomment-2578625757 @kevinjqliu conflict is resolved. As the PR is approved but not merged for over a month now, hence merge conflicts happen occasionally. -- This is an automated messa

Re: [PR] Add `all_manifests` metadata table with tests [iceberg-python]

kevinjqliu commented on PR #1241: URL: https://github.com/apache/iceberg-python/pull/1241#issuecomment-2576706003 @soumya-ghosh do you mind resolving the conflict? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Add `all_manifests` metadata table with tests [iceberg-python]

soumya-ghosh commented on PR #1241: URL: https://github.com/apache/iceberg-python/pull/1241#issuecomment-2536965547 @Fokko bumping this up for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Add `all_manifests` metadata table with tests [iceberg-python]

kevinjqliu commented on code in PR #1241: URL: https://github.com/apache/iceberg-python/pull/1241#discussion_r1850946579 ## pyiceberg/table/inspect.py: ## @@ -405,13 +419,19 @@ def _partition_summaries_to_rows( "partition_summaries": _partition_summaries_to

Re: [PR] Add `all_manifests` metadata table with tests [iceberg-python]

soumya-ghosh commented on PR #1241: URL: https://github.com/apache/iceberg-python/pull/1241#issuecomment-2487895650 Hey @Fokko nothing major is pending on my side, awaiting your approval. I will resolve the conflicts shortly. -- This is an automated message from the Apache Git Service. To

Re: [PR] Add `all_manifests` metadata table with tests [iceberg-python]

Fokko commented on PR #1241: URL: https://github.com/apache/iceberg-python/pull/1241#issuecomment-2486890621 @soumya-ghosh I see this one is still pending, are you still interested to get this in? -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] Add `all_manifests` metadata table with tests [iceberg-python]

soumya-ghosh commented on code in PR #1241: URL: https://github.com/apache/iceberg-python/pull/1241#discussion_r1819462207 ## pyiceberg/table/inspect.py: ## @@ -405,13 +419,19 @@ def _partition_summaries_to_rows( "partition_summaries": _partition_summaries_

Re: [PR] Add `all_manifests` metadata table with tests [iceberg-python]

soumya-ghosh commented on code in PR #1241: URL: https://github.com/apache/iceberg-python/pull/1241#discussion_r1819502718 ## tests/integration/test_inspect_table.py: ## @@ -846,3 +846,95 @@ def inspect_files_asserts(df: pa.Table) -> None: inspect_files_asserts(files_df)

Re: [PR] Add `all_manifests` metadata table with tests [iceberg-python]

soumya-ghosh commented on code in PR #1241: URL: https://github.com/apache/iceberg-python/pull/1241#discussion_r1819441241 ## pyiceberg/table/inspect.py: ## @@ -405,13 +419,19 @@ def _partition_summaries_to_rows( "partition_summaries": _partition_summaries_

Re: [PR] Add `all_manifests` metadata table with tests [iceberg-python]

kevinjqliu commented on code in PR #1241: URL: https://github.com/apache/iceberg-python/pull/1241#discussion_r1819434903 ## pyiceberg/table/inspect.py: ## @@ -405,13 +419,19 @@ def _partition_summaries_to_rows( "partition_summaries": _partition_summaries_to

Re: [PR] Add `all_manifests` metadata table with tests [iceberg-python]

soumya-ghosh commented on code in PR #1241: URL: https://github.com/apache/iceberg-python/pull/1241#discussion_r1819013784 ## pyiceberg/table/inspect.py: ## @@ -32,6 +33,41 @@ from pyiceberg.table import Table +def get_manifests_schema() -> "pa.Schema": Review Comment:

Re: [PR] Add `all_manifests` metadata table with tests [iceberg-python]

soumya-ghosh commented on code in PR #1241: URL: https://github.com/apache/iceberg-python/pull/1241#discussion_r1818514795 ## pyiceberg/table/inspect.py: ## @@ -32,6 +33,41 @@ from pyiceberg.table import Table +def get_manifests_schema() -> "pa.Schema": +import pyar

Re: [PR] Add `all_manifests` metadata table with tests [iceberg-python]

soumya-ghosh commented on code in PR #1241: URL: https://github.com/apache/iceberg-python/pull/1241#discussion_r1818515731 ## pyiceberg/table/inspect.py: ## @@ -405,13 +419,19 @@ def _partition_summaries_to_rows( "partition_summaries": _partition_summaries_

Re: [PR] Add `all_manifests` metadata table with tests [iceberg-python]

kevinjqliu commented on code in PR #1241: URL: https://github.com/apache/iceberg-python/pull/1241#discussion_r1818300495 ## pyiceberg/table/inspect.py: ## @@ -32,6 +33,41 @@ from pyiceberg.table import Table +def get_manifests_schema() -> "pa.Schema": Review Comment: