soumya-ghosh commented on code in PR #1241:
URL: https://github.com/apache/iceberg-python/pull/1241#discussion_r1819462207
##########
pyiceberg/table/inspect.py:
##########
@@ -405,13 +419,19 @@ def _partition_summaries_to_rows(
"partition_summaries":
_partition_summaries_to_rows(specs[manifest.partition_spec_id],
manifest.partitions)
if manifest.partitions
else [],
- })
+ }
+ if is_all_manifests_table:
+ manifest_row["reference_snapshot_id"] =
snapshot.snapshot_id
+ manifests.append(manifest_row)
return pa.Table.from_pylist(
manifests,
- schema=manifest_schema,
+ schema=get_all_manifests_schema() if is_all_manifests_table else
get_manifests_schema(),
)
+ def manifests(self) -> "pa.Table":
Review Comment:
Yeah, I am aligned with this.
But there are two parameters that I'm passing to `_generate_manifests_table`
method - snapshot_id and a boolean flag whether the output is for all_manifests
table which add the additional column to `all_manifests` table.
So I'll need to add this second parameter for manifests method as well.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
