soumya-ghosh commented on code in PR #1241:
URL: https://github.com/apache/iceberg-python/pull/1241#discussion_r1818515731


##########
pyiceberg/table/inspect.py:
##########
@@ -405,13 +419,19 @@ def _partition_summaries_to_rows(
                     "partition_summaries": 
_partition_summaries_to_rows(specs[manifest.partition_spec_id], 
manifest.partitions)
                     if manifest.partitions
                     else [],
-                })
+                }
+                if is_all_manifests_table:
+                    manifest_row["reference_snapshot_id"] = 
snapshot.snapshot_id

Review Comment:
   Yes, 
https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/AllManifestsTable.java#L144
 and 
https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/AllManifestsTable.java#L170



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to