Re: [PR] Deprecate DynamoDB Catalog to Reduce Catalog Scope [iceberg-python]

2024-02-27 Thread via GitHub
geruh commented on code in PR #475: URL: https://github.com/apache/iceberg-python/pull/475#discussion_r1505155942 ## pyiceberg/catalog/dynamodb.py: ## @@ -81,6 +82,10 @@ ITEM = "Item" +@deprecated( +deprecated_in="0.6.0", Review Comment: Hey @hussein-awala, yeah I a

Re: [PR] Deprecate DynamoDB Catalog to Reduce Catalog Scope [iceberg-python]

2024-02-27 Thread via GitHub
geruh commented on PR #475: URL: https://github.com/apache/iceberg-python/pull/475#issuecomment-1967930755 > Ah, just saw this comment: [apache/iceberg#9783 (comment)](https://github.com/apache/iceberg/pull/9783#issuecomment-1965781361). So maybe we can wait for a while to see how the discu

Re: [PR] Deprecate DynamoDB Catalog to Reduce Catalog Scope [iceberg-python]

2024-02-27 Thread via GitHub
geruh commented on code in PR #475: URL: https://github.com/apache/iceberg-python/pull/475#discussion_r1505155942 ## pyiceberg/catalog/dynamodb.py: ## @@ -81,6 +82,10 @@ ITEM = "Item" +@deprecated( +deprecated_in="0.6.0", Review Comment: Hey @hussein-awala, yeah we

Re: [PR] Deprecate DynamoDB Catalog to Reduce Catalog Scope [iceberg-python]

2024-02-27 Thread via GitHub
hussein-awala commented on code in PR #475: URL: https://github.com/apache/iceberg-python/pull/475#discussion_r1505068598 ## pyiceberg/catalog/dynamodb.py: ## @@ -81,6 +82,10 @@ ITEM = "Item" +@deprecated( +deprecated_in="0.6.0", Review Comment: `0.6.0` was already

Re: [PR] Deprecate DynamoDB Catalog to Reduce Catalog Scope [iceberg-python]

2024-02-27 Thread via GitHub
geruh commented on code in PR #475: URL: https://github.com/apache/iceberg-python/pull/475#discussion_r1504938114 ## pyiceberg/catalog/dynamodb.py: ## @@ -81,6 +82,10 @@ ITEM = "Item" +@deprecated( +deprecated_in="0.6.0", +removed_in="1.0.0", +) Review Comment:

Re: [PR] Deprecate DynamoDB Catalog to Reduce Catalog Scope [iceberg-python]

2024-02-26 Thread via GitHub
HonahX commented on PR #475: URL: https://github.com/apache/iceberg-python/pull/475#issuecomment-1965871433 Ah, just saw this comment: https://github.com/apache/iceberg/pull/9783#issuecomment-1965781361. So maybe we can wait for a while to see how the discussion goes, -- This is an autom

Re: [PR] Deprecate DynamoDB Catalog to Reduce Catalog Scope [iceberg-python]

2024-02-26 Thread via GitHub
HonahX commented on code in PR #475: URL: https://github.com/apache/iceberg-python/pull/475#discussion_r1503700463 ## pyiceberg/catalog/dynamodb.py: ## @@ -81,6 +82,10 @@ ITEM = "Item" +@deprecated( +deprecated_in="0.6.0", +removed_in="1.0.0", +) Review Comment: