geruh commented on code in PR #475: URL: https://github.com/apache/iceberg-python/pull/475#discussion_r1504938114
########## pyiceberg/catalog/dynamodb.py: ########## @@ -81,6 +82,10 @@ ITEM = "Item" +@deprecated( + deprecated_in="0.6.0", + removed_in="1.0.0", +) Review Comment: What additional information should be added here for the deprecation method. Also, yeah the `deprecated` implementation implies that the `help_message` is optional and the warning goes against that behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
