HonahX commented on code in PR #475: URL: https://github.com/apache/iceberg-python/pull/475#discussion_r1503700463
########## pyiceberg/catalog/dynamodb.py: ########## @@ -81,6 +82,10 @@ ITEM = "Item" +@deprecated( + deprecated_in="0.6.0", + removed_in="1.0.0", +) Review Comment: Shall we add some `help_message=` here? Otherwise, the outcome message becomes ``` DeprecationWarning: Call to DynamoDbCatalog, deprecated in 0.6.0, will be removed in 1.0.0.None ``` where the `None` is printed out. We could also modify the `deprecated`'s implementation to remove the `None` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
