Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

2024-11-12 Thread via GitHub
github-actions[bot] commented on PR #9804: URL: https://github.com/apache/iceberg/pull/9804#issuecomment-2471993254 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

2024-11-12 Thread via GitHub
github-actions[bot] closed pull request #9804: [AWS] S3FileIO - Add Cross-Region Bucket Access URL: https://github.com/apache/iceberg/pull/9804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

2024-11-04 Thread via GitHub
github-actions[bot] commented on PR #9804: URL: https://github.com/apache/iceberg/pull/9804#issuecomment-2455962958 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

2024-10-17 Thread via GitHub
munendrasn commented on PR #11259: URL: https://github.com/apache/iceberg/pull/11259#issuecomment-2419818422 Thanks @ebelgasmi12 for the original changes, Thank you all for the review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

2024-10-14 Thread via GitHub
jackye1995 commented on PR #11259: URL: https://github.com/apache/iceberg/pull/11259#issuecomment-2411832407 > I meant the AwsClientProperties client.region. I believe it is still mandatory, no? No I don't think it is mandatory, I never set this in my sessions at least. If you find i

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

2024-10-14 Thread via GitHub
flyrain commented on PR #11259: URL: https://github.com/apache/iceberg/pull/11259#issuecomment-2411809860 Thanks @munendrasn for the PR. Thanks all for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

2024-10-14 Thread via GitHub
flyrain merged PR #11259: URL: https://github.com/apache/iceberg/pull/11259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

2024-10-14 Thread via GitHub
flyrain commented on PR #11259: URL: https://github.com/apache/iceberg/pull/11259#issuecomment-2411808387 @jackye1995, I meant the `AwsClientProperties` `client.region`. I believe it is still mandatory, no? To be clear, it is not related to this PR. I was wondering it since s3 basically can

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

2024-10-10 Thread via GitHub
jackye1995 commented on PR #11259: URL: https://github.com/apache/iceberg/pull/11259#issuecomment-2405262111 > Wondering if the aws client can allow missing the client.region config now @flyrain what do you mean by this? I think that config has been optional? And it will try to resol

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

2024-10-10 Thread via GitHub
munendrasn commented on PR #11259: URL: https://github.com/apache/iceberg/pull/11259#issuecomment-2405207488 @flyrain @singhpk234 @jackye1995 @RussellSpitzer If the changes looks good, would it be possible merge the changes? It would great if this can make it to 1.7 release FYI @ebelgasm

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

2024-07-18 Thread via GitHub
sfc-gh-schen commented on PR #9804: URL: https://github.com/apache/iceberg/pull/9804#issuecomment-2237119397 Hi, what is blocking from merging this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

2024-02-27 Thread via GitHub
elmehdibelgasmi commented on code in PR #9804: URL: https://github.com/apache/iceberg/pull/9804#discussion_r1504368735 ## aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIOProperties.java: ## @@ -439,6 +449,7 @@ public void testApplyS3ServiceConfigurations() { Arg

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

2024-02-27 Thread via GitHub
elmehdibelgasmi commented on code in PR #9804: URL: https://github.com/apache/iceberg/pull/9804#discussion_r1504358756 ## docs/docs/aws.md: ## @@ -500,6 +500,13 @@ spark-sql --conf spark.sql.catalog.my_catalog=org.apache.iceberg.spark.SparkCata For more details on using S3 A

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

2024-02-27 Thread via GitHub
ebelgasmi12 commented on code in PR #9804: URL: https://github.com/apache/iceberg/pull/9804#discussion_r1504357156 ## docs/docs/aws.md: ## @@ -500,6 +500,13 @@ spark-sql --conf spark.sql.catalog.my_catalog=org.apache.iceberg.spark.SparkCata For more details on using S3 Acces

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

2024-02-27 Thread via GitHub
ebelgasmi12 commented on code in PR #9804: URL: https://github.com/apache/iceberg/pull/9804#discussion_r1504357156 ## docs/docs/aws.md: ## @@ -500,6 +500,13 @@ spark-sql --conf spark.sql.catalog.my_catalog=org.apache.iceberg.spark.SparkCata For more details on using S3 Acces

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

2024-02-26 Thread via GitHub
geruh commented on code in PR #9804: URL: https://github.com/apache/iceberg/pull/9804#discussion_r1503279807 ## docs/docs/aws.md: ## @@ -500,6 +500,13 @@ spark-sql --conf spark.sql.catalog.my_catalog=org.apache.iceberg.spark.SparkCata For more details on using S3 Access Gran

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

2024-02-26 Thread via GitHub
elmehdibelgasmi commented on code in PR #9804: URL: https://github.com/apache/iceberg/pull/9804#discussion_r1503103822 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java: ## @@ -356,6 +356,16 @@ public class S3FileIOProperties implements Serializable { p

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

2024-02-26 Thread via GitHub
jackye1995 commented on code in PR #9804: URL: https://github.com/apache/iceberg/pull/9804#discussion_r1503096129 ## aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIOProperties.java: ## @@ -439,6 +449,7 @@ public void testApplyS3ServiceConfigurations() { Argument

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

2024-02-26 Thread via GitHub
jackye1995 commented on code in PR #9804: URL: https://github.com/apache/iceberg/pull/9804#discussion_r1503094756 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java: ## @@ -356,6 +356,16 @@ public class S3FileIOProperties implements Serializable { public

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

2024-02-26 Thread via GitHub
amogh-jahagirdar commented on code in PR #9804: URL: https://github.com/apache/iceberg/pull/9804#discussion_r1503057978 ## aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIOProperties.java: ## @@ -439,6 +449,7 @@ public void testApplyS3ServiceConfigurations() { Ar

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

2024-02-26 Thread via GitHub
elmehdibelgasmi commented on code in PR #9804: URL: https://github.com/apache/iceberg/pull/9804#discussion_r1502261145 ## aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIOProperties.java: ## @@ -439,6 +449,7 @@ public void testApplyS3ServiceConfigurations() { Arg

Re: [PR] [AWS] S3FileIO - Add Cross-Region Bucket Access [iceberg]

2024-02-25 Thread via GitHub
nastra commented on code in PR #9804: URL: https://github.com/apache/iceberg/pull/9804#discussion_r1502143236 ## aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIOProperties.java: ## @@ -439,6 +449,7 @@ public void testApplyS3ServiceConfigurations() { ArgumentCapt