pvary commented on PR #11196:
URL: https://github.com/apache/iceberg/pull/11196#issuecomment-2614939708
@lurnagao-dahua: Could you please link the dev list discussion? Were there
any comments on your message?
--
This is an automated message from the Apache Git Service.
To respond to the m
lurnagao-dahua commented on PR #11196:
URL: https://github.com/apache/iceberg/pull/11196#issuecomment-2614237241
> @lurnagao-dahua thank you for creating a PR, are there any plans to
re-open this PR?
I can reopen it at any time, but the community seems to have no plans.
--
This is an a
mayankvadariya commented on PR #11196:
URL: https://github.com/apache/iceberg/pull/11196#issuecomment-2607563392
@lurnagao-dahua thank you for creating a PR, are there any plans to re-open
this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
github-actions[bot] closed pull request #11196: update PartitionSpec with
snapshot'schema
URL: https://github.com/apache/iceberg/pull/11196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
github-actions[bot] commented on PR #11196:
URL: https://github.com/apache/iceberg/pull/11196#issuecomment-2537466436
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If
github-actions[bot] commented on PR #11196:
URL: https://github.com/apache/iceberg/pull/11196#issuecomment-2518818169
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
pvary commented on PR #11196:
URL: https://github.com/apache/iceberg/pull/11196#issuecomment-2454877367
Based on the doc, the change looks good.
I would write an email to the dev list though, since this is a behavioural
change, to highlight it to the community.
--
This is an automated
lurnagao-dahua commented on PR #11196:
URL: https://github.com/apache/iceberg/pull/11196#issuecomment-2376685075
Thank you very much for the review. @pvary @nastra
I have made the corresponding changes. Could you please take a review when
you have time?
--
This is an automated messag
nastra commented on code in PR #11196:
URL: https://github.com/apache/iceberg/pull/11196#discussion_r1774844030
##
core/src/test/java/org/apache/iceberg/DataTableScanTestBase.java:
##
@@ -309,4 +310,14 @@ public void testManifestLocationsInScanWithDeleteFiles()
throws IOExcepti
nastra commented on PR #11196:
URL: https://github.com/apache/iceberg/pull/11196#issuecomment-2373473827
> Could we have a test for all of the documented use-cases:
>
> ```
> -- time travel to October 26, 1986 at 01:21:00 -> uses the snapshot's
schema
> SELECT * FROM prod.db.tab
pvary commented on code in PR #11196:
URL: https://github.com/apache/iceberg/pull/11196#discussion_r1774802463
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -719,7 +719,7 @@ public TableMetadata upgradeToFormatVersion(int
newFormatVersion) {
return new
pvary commented on code in PR #11196:
URL: https://github.com/apache/iceberg/pull/11196#discussion_r1774798448
##
core/src/test/java/org/apache/iceberg/DataTableScanTestBase.java:
##
@@ -309,4 +310,14 @@ public void testManifestLocationsInScanWithDeleteFiles()
throws IOExceptio
pvary commented on PR #11196:
URL: https://github.com/apache/iceberg/pull/11196#issuecomment-2373413818
Could we have a test for all of the documented use-cases:
```
-- time travel to October 26, 1986 at 01:21:00 -> uses the snapshot's schema
SELECT * FROM prod.db.table TIMESTAMP AS
lurnagao-dahua commented on PR #11196:
URL: https://github.com/apache/iceberg/pull/11196#issuecomment-2372822799
Could you please take a review when you have time? @pvary @nastra @Fokko
I would greatly appreciate it!
--
This is an automated message from the Apache Git Service.
To respon
14 matches
Mail list logo
