nastra commented on PR #11196: URL: https://github.com/apache/iceberg/pull/11196#issuecomment-2373473827
> Could we have a test for all of the documented use-cases: > > ``` > -- time travel to October 26, 1986 at 01:21:00 -> uses the snapshot's schema > SELECT * FROM prod.db.table TIMESTAMP AS OF '1986-10-26 01:21:00'; > > -- time travel to snapshot with id 10963874102873L -> uses the snapshot's schema > SELECT * FROM prod.db.table VERSION AS OF 10963874102873; > > -- time travel to the head of audit-branch -> uses the table's schema > SELECT * FROM prod.db.table VERSION AS OF 'audit-branch'; > SELECT * FROM prod.db.table.`branch_audit-branch`; > > -- time travel to the snapshot referenced by the tag historical-snapshot -> uses the snapshot's schema > SELECT * FROM prod.db.table VERSION AS OF 'historical-snapshot'; > SELECT * FROM prod.db.table.`tag_historical-snapshot`; > ``` I believe we should have that already in `TestSelect`. @lurnagao-dahua can you double-check please if there's a gap in `TestSelect` that doesn't cover any of these queries? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
