nastra commented on code in PR #11196: URL: https://github.com/apache/iceberg/pull/11196#discussion_r1774844030
########## core/src/test/java/org/apache/iceberg/DataTableScanTestBase.java: ########## @@ -309,4 +310,14 @@ public void testManifestLocationsInScanWithDeleteFiles() throws IOException { .get(0); assertThat(deletes.get(0).manifestLocation()).isEqualTo(deleteManifest.path()); } + + @TestTemplate + public void testTimeTravelScanWithAlterColumn() throws Exception { + table.newFastAppend().appendFile(FILE_A).appendFile(FILE_B).commit(); + long timeTravelSnapshotId = table.currentSnapshot().snapshotId(); + table.updateSchema().renameColumn("id", "re_id").commit(); + TableScan scan = + table.newScan().useSnapshot(timeTravelSnapshotId).filter(Expressions.equal("id", 5)); + assertThat(Iterables.size(scan.planFiles())).isEqualTo(2); Review Comment: ```suggestion assertThat(scan.planFiles()).hasSize(2); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org