Re: [PR] refactor: iceberg::spec::values::Struct to remove bitvec [iceberg-rust]

2025-04-12 Thread via GitHub
Xuanwo merged PR #1203: URL: https://github.com/apache/iceberg-rust/pull/1203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] refactor: iceberg::spec::values::Struct to remove bitvec [iceberg-rust]

2025-04-12 Thread via GitHub
xxchan commented on code in PR #1203: URL: https://github.com/apache/iceberg-rust/pull/1203#discussion_r2040666986 ## crates/iceberg/src/spec/values.rs: ## @@ -1726,102 +1725,53 @@ impl Literal { #[derive(Debug, Clone, PartialEq, Eq, Hash)] pub struct Struct { /// Vector

Re: [PR] refactor: iceberg::spec::values::Struct to remove bitvec [iceberg-rust]

2025-04-12 Thread via GitHub
xxchan commented on code in PR #1203: URL: https://github.com/apache/iceberg-rust/pull/1203#discussion_r2040667397 ## .github/workflows/ci.yml: ## @@ -144,7 +144,7 @@ jobs: cargo generate-lockfile -Z direct-minimal-versions -Z minimal-versions # Some depen

Re: [PR] refactor: iceberg::spec::values::Struct to remove bitvec [iceberg-rust]

2025-04-12 Thread via GitHub
xxchan commented on code in PR #1203: URL: https://github.com/apache/iceberg-rust/pull/1203#discussion_r2040666986 ## crates/iceberg/src/spec/values.rs: ## @@ -1726,102 +1725,53 @@ impl Literal { #[derive(Debug, Clone, PartialEq, Eq, Hash)] pub struct Struct { /// Vector

Re: [PR] refactor: iceberg::spec::values::Struct to remove bitvec [iceberg-rust]

2025-04-12 Thread via GitHub
liurenjie1024 commented on PR #1203: URL: https://github.com/apache/iceberg-rust/pull/1203#issuecomment-2798698081 Wait for @Xuanwo to take another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] refactor: iceberg::spec::values::Struct to remove bitvec [iceberg-rust]

2025-04-12 Thread via GitHub
liurenjie1024 commented on code in PR #1203: URL: https://github.com/apache/iceberg-rust/pull/1203#discussion_r2040593754 ## .github/workflows/ci.yml: ## @@ -144,7 +144,7 @@ jobs: cargo generate-lockfile -Z direct-minimal-versions -Z minimal-versions # Som

Re: [PR] refactor: iceberg::spec::values::Struct to remove bitvec [iceberg-rust]

2025-04-11 Thread via GitHub
xxchan commented on code in PR #1203: URL: https://github.com/apache/iceberg-rust/pull/1203#discussion_r2040563802 ## Cargo.toml: ## @@ -55,14 +55,14 @@ async-trait = "0.1.86" aws-config = "1" aws-sdk-glue = "1.39" bimap = "0.6" -bitvec = "1.0.1" Review Comment: removed

Re: [PR] refactor: iceberg::spec::values::Struct to remove bitvec [iceberg-rust]

2025-04-11 Thread via GitHub
Xuanwo commented on code in PR #1203: URL: https://github.com/apache/iceberg-rust/pull/1203#discussion_r2040542931 ## Cargo.toml: ## @@ -55,14 +55,14 @@ async-trait = "0.1.86" aws-config = "1" aws-sdk-glue = "1.39" bimap = "0.6" -bitvec = "1.0.1" Review Comment: Thank for