Re: [PR] refactor: Adopt ObjectProvider in Table [iceberg-rust]

2025-04-23 Thread via GitHub
Xuanwo commented on code in PR #1227: URL: https://github.com/apache/iceberg-rust/pull/1227#discussion_r2056204238 ## crates/iceberg/src/spec/manifest_list.rs: ## @@ -656,7 +658,29 @@ impl ManifestFile { /// Load [`Manifest`]. /// /// This method will also initial

Re: [PR] refactor: Adopt ObjectProvider in Table [iceberg-rust]

2025-04-23 Thread via GitHub
liurenjie1024 commented on code in PR #1227: URL: https://github.com/apache/iceberg-rust/pull/1227#discussion_r2055996987 ## crates/iceberg/src/spec/manifest_list.rs: ## @@ -656,7 +658,29 @@ impl ManifestFile { /// Load [`Manifest`]. /// /// This method will also

Re: [PR] refactor: Adopt ObjectProvider in Table [iceberg-rust]

2025-04-22 Thread via GitHub
sdd commented on code in PR #1227: URL: https://github.com/apache/iceberg-rust/pull/1227#discussion_r2054607716 ## crates/iceberg/src/spec/manifest_list.rs: ## @@ -656,7 +658,29 @@ impl ManifestFile { /// Load [`Manifest`]. /// /// This method will also initialize

Re: [PR] refactor: Adopt ObjectProvider in Table [iceberg-rust]

2025-04-22 Thread via GitHub
liurenjie1024 commented on code in PR #1227: URL: https://github.com/apache/iceberg-rust/pull/1227#discussion_r2053499980 ## crates/iceberg/src/spec/manifest_list.rs: ## @@ -656,7 +658,29 @@ impl ManifestFile { /// Load [`Manifest`]. /// /// This method will also

Re: [PR] refactor: Adopt ObjectProvider in Table [iceberg-rust]

2025-04-22 Thread via GitHub
sdd commented on code in PR #1227: URL: https://github.com/apache/iceberg-rust/pull/1227#discussion_r2053486295 ## crates/iceberg/src/spec/manifest_list.rs: ## @@ -656,7 +658,29 @@ impl ManifestFile { /// Load [`Manifest`]. /// /// This method will also initialize

Re: [PR] refactor: Adopt ObjectProvider in Table [iceberg-rust]

2025-04-18 Thread via GitHub
liurenjie1024 commented on code in PR #1227: URL: https://github.com/apache/iceberg-rust/pull/1227#discussion_r2051359067 ## crates/iceberg/src/spec/manifest_list.rs: ## @@ -656,7 +658,29 @@ impl ManifestFile { /// Load [`Manifest`]. /// /// This method will also

Re: [PR] refactor: Adopt ObjectProvider in Table [iceberg-rust]

2025-04-18 Thread via GitHub
Xuanwo commented on code in PR #1227: URL: https://github.com/apache/iceberg-rust/pull/1227#discussion_r2050704642 ## crates/iceberg/src/spec/manifest_list.rs: ## @@ -656,7 +658,29 @@ impl ManifestFile { /// Load [`Manifest`]. /// /// This method will also initial

Re: [PR] refactor: Adopt ObjectProvider in Table [iceberg-rust]

2025-04-18 Thread via GitHub
Xuanwo commented on code in PR #1227: URL: https://github.com/apache/iceberg-rust/pull/1227#discussion_r2050704642 ## crates/iceberg/src/spec/manifest_list.rs: ## @@ -656,7 +658,29 @@ impl ManifestFile { /// Load [`Manifest`]. /// /// This method will also initial

Re: [PR] refactor: Adopt ObjectProvider in Table [iceberg-rust]

2025-04-18 Thread via GitHub
liurenjie1024 commented on code in PR #1227: URL: https://github.com/apache/iceberg-rust/pull/1227#discussion_r2050619904 ## crates/iceberg/src/spec/manifest_list.rs: ## @@ -656,7 +658,29 @@ impl ManifestFile { /// Load [`Manifest`]. /// /// This method will also

Re: [PR] refactor: Adopt ObjectProvider in Table [iceberg-rust]

2025-04-18 Thread via GitHub
Xuanwo commented on code in PR #1227: URL: https://github.com/apache/iceberg-rust/pull/1227#discussion_r2050607042 ## crates/iceberg/src/spec/manifest_list.rs: ## @@ -656,7 +658,29 @@ impl ManifestFile { /// Load [`Manifest`]. /// /// This method will also initial

Re: [PR] refactor: Adopt ObjectProvider in Table [iceberg-rust]

2025-04-18 Thread via GitHub
liurenjie1024 commented on code in PR #1227: URL: https://github.com/apache/iceberg-rust/pull/1227#discussion_r2050600968 ## crates/iceberg/src/spec/manifest_list.rs: ## @@ -656,7 +658,29 @@ impl ManifestFile { /// Load [`Manifest`]. /// /// This method will also

[PR] refactor: Adopt ObjectProvider in Table [iceberg-rust]

2025-04-18 Thread via GitHub
Xuanwo opened a new pull request, #1227: URL: https://github.com/apache/iceberg-rust/pull/1227 ## Which issue does this PR close? Part of https://github.com/apache/iceberg-rust/issues/1226 ## What changes are included in this PR? This PR unlock our users to use an