liurenjie1024 commented on code in PR #1227:
URL: https://github.com/apache/iceberg-rust/pull/1227#discussion_r2050600968
##########
crates/iceberg/src/spec/manifest_list.rs:
##########
@@ -656,7 +658,29 @@ impl ManifestFile {
/// Load [`Manifest`].
///
/// This method will also initialize inherited values of
[`ManifestEntry`], such as `sequence_number`.
- pub async fn load_manifest(&self, file_io: &FileIO) -> Result<Manifest> {
+ ///
+ /// If `object_cache` is provided, it will be used to cache the manifest.
+ pub async fn load_manifest(
Review Comment:
I think we should keep the original public api, while keeping the one with
cache provider crate private. The version with cache provider is more likely
being called by internal usage.
##########
crates/iceberg/src/spec/snapshot.rs:
##########
@@ -186,9 +187,35 @@ impl Snapshot {
/// Load manifest list.
pub async fn load_manifest_list(
&self,
+ table_metadata: &TableMetadata,
file_io: &FileIO,
+ object_cache: Option<&ObjectCacheProvider>,
Review Comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
