liurenjie1024 commented on code in PR #1227:
URL: https://github.com/apache/iceberg-rust/pull/1227#discussion_r2055996987


##########
crates/iceberg/src/spec/manifest_list.rs:
##########
@@ -656,7 +658,29 @@ impl ManifestFile {
     /// Load [`Manifest`].
     ///
     /// This method will also initialize inherited values of 
[`ManifestEntry`], such as `sequence_number`.
-    pub async fn load_manifest(&self, file_io: &FileIO) -> Result<Manifest> {
+    ///
+    /// If `object_cache` is provided, it will be used to cache the manifest.
+    pub async fn load_manifest(

Review Comment:
   > Are you thinking that the table scan plan would itself use the 
ManifestLoader also, internally?
   
   I think we should also use `ManifestLoader` internally if we can, so that 
advanced users colud learn how to use them for source code. But if there is a 
strong reason we can't do it that way, I'm open to other solutions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to