Re: [PR] refactor!: Change FileIO::remove_all to remove_dir_all [iceberg-rust]

2025-05-05 Thread via GitHub
Xuanwo commented on PR #1275: URL: https://github.com/apache/iceberg-rust/pull/1275#issuecomment-2853180021 Thank you all for the review, I will start addressing them today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] refactor!: Change FileIO::remove_all to remove_dir_all [iceberg-rust]

2025-05-05 Thread via GitHub
liurenjie1024 commented on code in PR #1275: URL: https://github.com/apache/iceberg-rust/pull/1275#discussion_r2074560657 ## crates/iceberg/src/io/file_io.rs: ## @@ -95,9 +95,14 @@ impl FileIO { /// # Arguments /// /// * path: It should be *absolute* path starting

Re: [PR] refactor!: Change FileIO::remove_all to remove_dir_all [iceberg-rust]

2025-05-05 Thread via GitHub
kevinjqliu commented on code in PR #1275: URL: https://github.com/apache/iceberg-rust/pull/1275#discussion_r2073866447 ## crates/iceberg/src/io/file_io.rs: ## @@ -95,9 +95,14 @@ impl FileIO { /// # Arguments /// /// * path: It should be *absolute* path starting wi

Re: [PR] refactor!: Change FileIO::remove_all to remove_dir_all [iceberg-rust]

2025-04-29 Thread via GitHub
liurenjie1024 commented on code in PR #1275: URL: https://github.com/apache/iceberg-rust/pull/1275#discussion_r2067912038 ## crates/iceberg/src/io/file_io.rs: ## @@ -95,9 +95,14 @@ impl FileIO { /// # Arguments /// /// * path: It should be *absolute* path starting

[PR] refactor!: Change FileIO::remove_all to remove_dir_all [iceberg-rust]

2025-04-29 Thread via GitHub
Xuanwo opened a new pull request, #1275: URL: https://github.com/apache/iceberg-rust/pull/1275 ## Which issue does this PR close? - Closes https://github.com/apache/iceberg-rust/issues/1118 ## What changes are included in this PR? Change FileIO::remove_all to rem