liurenjie1024 commented on code in PR #1275:
URL: https://github.com/apache/iceberg-rust/pull/1275#discussion_r2067912038
##########
crates/iceberg/src/io/file_io.rs:
##########
@@ -95,9 +95,14 @@ impl FileIO {
/// # Arguments
///
/// * path: It should be *absolute* path starting with scheme string used
to construct [`FileIO`].
- pub async fn remove_all(&self, path: impl AsRef<str>) -> Result<()> {
+ pub async fn remove_dir_all(&self, path: impl AsRef<str>) -> Result<()> {
Review Comment:
1. It would be better to add doc to explain the behavior, e.g. what if the
dir doesn't exist, what if the dir is empty.
2. Add test case for path not ending with "/"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
