kevinjqliu commented on code in PR #1275:
URL: https://github.com/apache/iceberg-rust/pull/1275#discussion_r2073866447
##########
crates/iceberg/src/io/file_io.rs:
##########
@@ -95,9 +95,14 @@ impl FileIO {
/// # Arguments
///
/// * path: It should be *absolute* path starting with scheme string used
to construct [`FileIO`].
- pub async fn remove_all(&self, path: impl AsRef<str>) -> Result<()> {
+ pub async fn remove_dir_all(&self, path: impl AsRef<str>) -> Result<()> {
Review Comment:
maybe also add a test for if the path (without ending in `/`) refers to a
file instead of dir. should be no-op
##########
crates/iceberg/src/io/file_io.rs:
##########
@@ -95,9 +95,14 @@ impl FileIO {
/// # Arguments
///
/// * path: It should be *absolute* path starting with scheme string used
to construct [`FileIO`].
- pub async fn remove_all(&self, path: impl AsRef<str>) -> Result<()> {
+ pub async fn remove_dir_all(&self, path: impl AsRef<str>) -> Result<()> {
Review Comment:
is this a breaking change? i.e. something we should warn users about on the
next release
##########
crates/iceberg/src/io/file_io.rs:
##########
@@ -95,9 +95,14 @@ impl FileIO {
/// # Arguments
///
/// * path: It should be *absolute* path starting with scheme string used
to construct [`FileIO`].
- pub async fn remove_all(&self, path: impl AsRef<str>) -> Result<()> {
+ pub async fn remove_dir_all(&self, path: impl AsRef<str>) -> Result<()> {
Review Comment:
[this
comment](https://github.com/apache/iceberg-rust/issues/1118#issuecomment-2766198351)
also mentions adding a `remove_dir` function for removing empty dir, do we
also want to add that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
