Fokko merged PR #80:
URL: https://github.com/apache/iceberg-rust/pull/80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
Fokko commented on PR #80:
URL: https://github.com/apache/iceberg-rust/pull/80#issuecomment-1768194413
Great catch @JanKaul and everyone for reviewing! Let's get this in!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
JanKaul commented on PR #80:
URL: https://github.com/apache/iceberg-rust/pull/80#issuecomment-1767817696
Thanks @ZENOTME for finding the bug!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
JanKaul commented on PR #80:
URL: https://github.com/apache/iceberg-rust/pull/80#issuecomment-1767813964
I added `impl From for Vec`. Now it should be clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
liurenjie1024 commented on PR #80:
URL: https://github.com/apache/iceberg-rust/pull/80#issuecomment-1767686793
> The PR looks good to me overall, but I'm slightly concerned about the use
of `Intointo(literal)`. Will our users have to write code in this
manner? Or does it occur internall
ZENOTME commented on code in PR #80:
URL: https://github.com/apache/iceberg-rust/pull/80#discussion_r1363200948
##
crates/iceberg/src/spec/values.rs:
##
@@ -995,7 +995,7 @@ mod tests {
assert_eq!(literal, expected_literal);
let mut writer = apache_avro::Write
Xuanwo commented on PR #80:
URL: https://github.com/apache/iceberg-rust/pull/80#issuecomment-1767645545
The PR looks good to me overall, but I'm slightly concerned about the use of
`Intointo(literal)`. Will our users have to write code in this
manner? Or does it occur internally?
--
ZENOTME commented on PR #80:
URL: https://github.com/apache/iceberg-rust/pull/80#issuecomment-1766094815
Thanks for your explanation! Totally understanded it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
JanKaul commented on code in PR #80:
URL: https://github.com/apache/iceberg-rust/pull/80#discussion_r1361806053
##
crates/iceberg/src/spec/values.rs:
##
@@ -995,7 +995,7 @@ mod tests {
assert_eq!(literal, expected_literal);
let mut writer = apache_avro::Write
JanKaul commented on PR #80:
URL: https://github.com/apache/iceberg-rust/pull/80#issuecomment-1766011191
I will try to explain it the best way I can. Please correct me if I'm wrong.
Iceberg defines it's own [binary serialization
format](https://iceberg.apache.org/spec/#binary-single-v
Xuanwo commented on code in PR #80:
URL: https://github.com/apache/iceberg-rust/pull/80#discussion_r1361762750
##
crates/iceberg/src/spec/values.rs:
##
@@ -995,7 +995,7 @@ mod tests {
assert_eq!(literal, expected_literal);
let mut writer = apache_avro::Writer
Xuanwo commented on code in PR #80:
URL: https://github.com/apache/iceberg-rust/pull/80#discussion_r1361762750
##
crates/iceberg/src/spec/values.rs:
##
@@ -995,7 +995,7 @@ mod tests {
assert_eq!(literal, expected_literal);
let mut writer = apache_avro::Writer
ZENOTME commented on PR #80:
URL: https://github.com/apache/iceberg-rust/pull/80#issuecomment-1765964478
I'm a little confused. So this avro bytes is different with [binary encoding
in avro
spec](https://avro.apache.org/docs/1.11.1/specification/#binary-encoding)?
What's difference between
JanKaul commented on code in PR #80:
URL: https://github.com/apache/iceberg-rust/pull/80#discussion_r1361754339
##
crates/iceberg/src/spec/values.rs:
##
@@ -995,7 +995,7 @@ mod tests {
assert_eq!(literal, expected_literal);
let mut writer = apache_avro::Write
Xuanwo commented on code in PR #80:
URL: https://github.com/apache/iceberg-rust/pull/80#discussion_r1361704555
##
crates/iceberg/src/spec/values.rs:
##
@@ -995,7 +995,7 @@ mod tests {
assert_eq!(literal, expected_literal);
let mut writer = apache_avro::Writer
JanKaul commented on code in PR #80:
URL: https://github.com/apache/iceberg-rust/pull/80#discussion_r1361690259
##
crates/iceberg/src/spec/values.rs:
##
@@ -995,7 +995,7 @@ mod tests {
assert_eq!(literal, expected_literal);
let mut writer = apache_avro::Write
Xuanwo commented on code in PR #80:
URL: https://github.com/apache/iceberg-rust/pull/80#discussion_r1361682216
##
crates/iceberg/src/spec/values.rs:
##
@@ -995,7 +995,7 @@ mod tests {
assert_eq!(literal, expected_literal);
let mut writer = apache_avro::Writer
JanKaul opened a new pull request, #80:
URL: https://github.com/apache/iceberg-rust/pull/80
This PR fixes a logical bug in the tests for converting `Literal`s to and
from `ByteBuf`. The bug is that I wrote the wrong bytes to the avro file.
--
This is an automated message from the Apache G
18 matches
Mail list logo
