JanKaul commented on code in PR #80:
URL: https://github.com/apache/iceberg-rust/pull/80#discussion_r1361754339
##########
crates/iceberg/src/spec/values.rs:
##########
@@ -995,7 +995,7 @@ mod tests {
assert_eq!(literal, expected_literal);
let mut writer = apache_avro::Writer::new(&schema, Vec::new());
- writer.append_ser(bytes).unwrap();
+ writer.append_ser(Into::<ByteBuf>::into(literal)).unwrap();
Review Comment:
There currently is no `Into<Vec<u8>>` for `Literal` but there is a
`From<Literal> for ByteBuf`, which I would like to use. When I use
`ByteBuf::from`, the compiler wants to use the existing `ByteBuf::from(value:
impl Into<Vec<u8>>)` implementation, which gives me a type error because
`Literal` doesn't implement `Into<Vec<u8>>`. So I need someway to tell the
compiler the right `from/into` implementation to use. It works the way I did it
but it might be a bit confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
