Xuanwo commented on PR #80: URL: https://github.com/apache/iceberg-rust/pull/80#issuecomment-1767645545
The PR looks good to me overall, but I'm slightly concerned about the use of `Into::<ByteBuf>::into(literal)`. Will our users have to write code in this manner? Or does it occur internally? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org