liurenjie1024 merged PR #442:
URL: https://github.com/apache/iceberg-rust/pull/442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
liurenjie1024 commented on code in PR #442:
URL: https://github.com/apache/iceberg-rust/pull/442#discussion_r1667343368
##
crates/iceberg/src/runtime/mod.rs:
##
@@ -26,6 +26,8 @@ pub enum JoinHandle {
Tokio(tokio::task::JoinHandle),
#[cfg(all(feature = "async-std", not
Xuanwo commented on code in PR #442:
URL: https://github.com/apache/iceberg-rust/pull/442#discussion_r1667337816
##
crates/iceberg/src/runtime/mod.rs:
##
@@ -26,6 +26,8 @@ pub enum JoinHandle {
Tokio(tokio::task::JoinHandle),
#[cfg(all(feature = "async-std", not(featur
Xuanwo commented on code in PR #442:
URL: https://github.com/apache/iceberg-rust/pull/442#discussion_r1667337922
##
crates/iceberg/src/runtime/mod.rs:
##
@@ -39,6 +41,8 @@ impl Future for JoinHandle {
.map(|h| h.expect("tokio spawned task failed")),
liurenjie1024 commented on code in PR #442:
URL: https://github.com/apache/iceberg-rust/pull/442#discussion_r1667328171
##
crates/iceberg/src/runtime/mod.rs:
##
@@ -67,6 +74,9 @@ where
#[cfg(all(feature = "async-std", not(feature = "tokio")))]
return JoinHandle::Asyn
Xuanwo opened a new pull request, #442:
URL: https://github.com/apache/iceberg-rust/pull/442
This PR will add feature gates for different storage services. Also fix some
feature related build error while `no-default-features` has been set.
--
This is an automated message from the Apache G
