Re: [PR] feat:add init expression interface. [iceberg-cpp]

Fokko commented on PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#issuecomment-2812067720 Thanks @yingcai-cy for working on this, and thanks @alonesniper, @gty404, @lidavidm, @wgtmac, @Xuanwo and @zhjwpku for the review 🙌 Great to have this in! -- This is an automated message

Re: [PR] feat:add init expression interface. [iceberg-cpp]

Fokko merged PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] feat:add init expression interface. [iceberg-cpp]

yingcai-cy commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2044060393 ## src/iceberg/expression.cc: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat:add init expression interface. [iceberg-cpp]

yingcai-cy commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2044081157 ## src/iceberg/expression.cc: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat:add init expression interface. [iceberg-cpp]

yingcai-cy commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2044070727 ## src/iceberg/expression.h: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat:add init expression interface. [iceberg-cpp]

yingcai-cy commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2044066985 ## src/iceberg/expression.cc: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat:add init expression interface. [iceberg-cpp]

Fokko commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2041542993 ## src/iceberg/expression.h: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat:add init expression interface. [iceberg-cpp]

Fokko commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2041519922 ## src/iceberg/expression.cc: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat:add init expression interface. [iceberg-cpp]

Fokko commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2041524600 ## src/iceberg/expression.h: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat:add init expression interface. [iceberg-cpp]

Fokko commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2041514451 ## src/iceberg/expression.cc: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat:add init expression interface. [iceberg-cpp]

lidavidm commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2041246684 ## test/expression_test.cc: ## Review Comment: This could benefit from a parameterized test ## src/iceberg/expression.cc: ## @@ -0,0 +1,65 @@ +

Re: [PR] feat:add init expression interface. [iceberg-cpp]

zhjwpku commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2040673571 ## test/expression_test.cc: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat:add init expression interface. [iceberg-cpp]

wgtmac commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2040669212 ## src/iceberg/expression.h: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat:add init expression interface. [iceberg-cpp]

yingcai-cy commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2040591689 ## src/iceberg/expression.h: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat:add init expression interface. [iceberg-cpp]

wgtmac commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2039645542 ## src/iceberg/expression.h: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat:add init expression interface. [iceberg-cpp]

yingcai-cy commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2039025237 ## src/iceberg/expression.h: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat:add init expression interface. [iceberg-cpp]

yingcai-cy commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2039021361 ## test/CMakeLists.txt: ## @@ -39,6 +39,11 @@ target_sources(expected_test PRIVATE expected_test.cc) target_link_libraries(expected_test PRIVATE iceberg_static GTes

Re: [PR] feat:add init expression interface. [iceberg-cpp]

yingcai-cy commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2031195962 ## src/iceberg/expression.cc: ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. Se

Re: [PR] feat:add init expression interface. [iceberg-cpp]

alonesniper commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2032877081 ## src/iceberg/expression.h: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. Se

Re: [PR] feat:add init expression interface. [iceberg-cpp]

lidavidm commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2031193620 ## src/iceberg/expression.h: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See t

Re: [PR] feat:add init expression interface. [iceberg-cpp]

yingcai-cy commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2031159579 ## src/iceberg/error.h: ## @@ -38,6 +38,8 @@ enum class ErrorKind { kNotImplemented, kUnknownError, kNotSupported, + kInvalidExpression, + kInvalidOperato

Re: [PR] feat:add init expression interface. [iceberg-cpp]

lidavidm commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2031195685 ## src/iceberg/expression.h: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See t

Re: [PR] feat:add init expression interface. [iceberg-cpp]

yingcai-cy commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2031157918 ## src/iceberg/expression.h: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat:add init expression interface. [iceberg-cpp]

yingcai-cy commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2031143729 ## src/iceberg/expression.h: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat:add init expression interface. [iceberg-cpp]

lidavidm commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2025773673 ## src/iceberg/expression.cc: ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat:add init expression interface. [iceberg-cpp]

yingcai-cy commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2024469563 ## src/iceberg/expression.h: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

[PR] feat:add init expression interface. [iceberg-cpp]

yingcai-cy opened a new pull request, #58: URL: https://github.com/apache/iceberg-cpp/pull/58 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] feat:add init expression interface. [iceberg-cpp]

yingcai-cy commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2024103491 ## src/iceberg/expression.h: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat:add init expression interface. [iceberg-cpp]

wgtmac commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2025893097 ## src/iceberg/expression.h: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat:add init expression interface. [iceberg-cpp]

wgtmac commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2025884055 ## src/iceberg/expression.h: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat:add init expression interface. [iceberg-cpp]

wgtmac commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2025870041 ## test/CMakeLists.txt: ## @@ -39,6 +39,11 @@ target_sources(expected_test PRIVATE expected_test.cc) target_link_libraries(expected_test PRIVATE iceberg_static GTest::g

Re: [PR] feat:add init expression interface. [iceberg-cpp]

lidavidm commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2025772416 ## src/iceberg/expression.h: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See t

Re: [PR] feat:add init expression interface. [iceberg-cpp]

zhjwpku commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2025025607 ## src/iceberg/expression.cc: ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See t

Re: [PR] feat:add init expression interface. [iceberg-cpp]

gty404 commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2024995368 ## src/iceberg/error.h: ## @@ -38,6 +38,8 @@ enum class ErrorKind { kNotImplemented, kUnknownError, kNotSupported, + kInvalidExpression, + kInvalidOperatorTyp

Re: [PR] feat:add init expression interface. [iceberg-cpp]

yingcai-cy commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2024469563 ## src/iceberg/expression.h: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat:add init expression interface. [iceberg-cpp]

lidavidm commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2024138415 ## src/iceberg/expression.h: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See t

Re: [PR] feat:add init expression interface. [iceberg-cpp]

lidavidm commented on code in PR #58: URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2024079986 ## src/iceberg/expression.h: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See t