JanKaul commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1392082466
##
crates/iceberg/src/avro/schema.rs:
##
@@ -233,23 +222,46 @@ pub(crate) fn schema_to_avro_schema(name: impl ToString,
schema: &Schema) -> Res
visit_schema(sche
JanKaul commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1392079536
##
crates/iceberg/src/spec/values.rs:
##
@@ -893,9 +925,9 @@ impl Literal {
PrimitiveLiteral::Binary(_) =>
Type::Primitive(PrimitiveType::Binary),
ZENOTME commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1390968160
##
crates/iceberg/src/spec/values.rs:
##
@@ -893,9 +925,9 @@ impl Literal {
PrimitiveLiteral::Binary(_) =>
Type::Primitive(PrimitiveType::Binary),
liurenjie1024 commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1390944513
##
crates/iceberg/src/spec/values.rs:
##
@@ -893,9 +925,9 @@ impl Literal {
PrimitiveLiteral::Binary(_) =>
Type::Primitive(PrimitiveType::Binar
ZENOTME commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1390902968
##
crates/iceberg/src/spec/values.rs:
##
@@ -893,9 +925,9 @@ impl Literal {
PrimitiveLiteral::Binary(_) =>
Type::Primitive(PrimitiveType::Binary),
ZENOTME commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1390890336
##
crates/iceberg/src/avro/schema.rs:
##
@@ -441,14 +453,35 @@ impl AvroSchemaVisitor for AvroSchemaToSchema {
AvroSchema::Date => Type::Primitive(Primiti
ZENOTME commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1390885977
##
crates/iceberg/src/avro/schema.rs:
##
@@ -233,23 +222,46 @@ pub(crate) fn schema_to_avro_schema(name: impl ToString,
schema: &Schema) -> Res
visit_schema(sche
Fokko merged PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
Fokko commented on PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#issuecomment-1807742634
I'll move this forward since it has been pending for a while (Sorry for
that!). I have one comment about ignoring the scale, which looks incorrect to
me. Thanks @ZENOTME for working on thi
Fokko commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1390768529
##
crates/iceberg/src/avro/schema.rs:
##
@@ -233,23 +222,46 @@ pub(crate) fn schema_to_avro_schema(name: impl ToString,
schema: &Schema) -> Res
visit_schema(schema
liurenjie1024 commented on PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#issuecomment-1801698341
cc @Xuanwo @Fokko Any other comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
ZENOTME commented on PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#issuecomment-1793387160
@Fokko Hi, we can run the check again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ZENOTME commented on PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#issuecomment-1788612183
My bad, have fixed the typos now.🥵
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
ZENOTME commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1374447735
##
crates/iceberg/src/avro/schema.rs:
##
@@ -30,6 +32,11 @@ use itertools::{Either, Itertools};
use serde_json::{Number, Value};
const FILED_ID_PROP: &str = "field
Xuanwo commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1374016647
##
crates/iceberg/src/spec/values.rs:
##
@@ -1309,4 +1981,277 @@ mod tests {
&Type::Primitive(PrimitiveType::String),
);
}
+
+#[test]
+
liurenjie1024 commented on PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#issuecomment-1776370231
cc @Fokko @Xuanwo @JanKaul PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
liurenjie1024 commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1369463348
##
crates/iceberg/src/spec/values.rs:
##
@@ -996,10 +1028,593 @@ mod timestamptz {
}
}
+mod _serde {
+use std::collections::BTreeMap;
+
+use crat
ZENOTME commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1369459787
##
crates/iceberg/src/spec/values.rs:
##
@@ -996,10 +1028,593 @@ mod timestamptz {
}
}
+mod _serde {
+use std::collections::BTreeMap;
+
+use crate::{
+
liurenjie1024 commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1369450219
##
crates/iceberg/src/spec/values.rs:
##
@@ -996,10 +1028,593 @@ mod timestamptz {
}
}
+mod _serde {
+use std::collections::BTreeMap;
+
+use crat
ZENOTME commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1368605517
##
crates/iceberg/src/spec/values.rs:
##
@@ -1309,4 +1928,256 @@ mod tests {
&Type::Primitive(PrimitiveType::String),
);
}
+
+#[test]
+
liurenjie1024 commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1368190040
##
crates/iceberg/src/avro/schema.rs:
##
@@ -431,14 +456,35 @@ impl AvroSchemaVisitor for AvroSchemaToSchema {
AvroSchema::Date => Type::Primitive(P
ZENOTME commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1367767663
##
crates/iceberg/src/spec/values.rs:
##
@@ -620,6 +622,47 @@ impl Struct {
}
}
+/// An iterator that moves out of a struct.
+pub struct StructIntoIter {
+
ZENOTME commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1367767559
##
crates/iceberg/src/spec/values.rs:
##
@@ -996,10 +1039,552 @@ mod timestamptz {
}
}
+mod _serde {
+use std::collections::BTreeMap;
+
+use crate::{
+
ZENOTME commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1367766620
##
crates/iceberg/src/spec/values.rs:
##
@@ -996,10 +1039,552 @@ mod timestamptz {
}
}
+mod _serde {
+use std::collections::BTreeMap;
+
+use crate::{
+
ZENOTME commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1367766620
##
crates/iceberg/src/spec/values.rs:
##
@@ -996,10 +1039,552 @@ mod timestamptz {
}
}
+mod _serde {
+use std::collections::BTreeMap;
+
+use crate::{
+
ZENOTME commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1367762809
##
crates/iceberg/src/spec/values.rs:
##
@@ -996,10 +1039,552 @@ mod timestamptz {
}
}
+mod _serde {
+use std::collections::BTreeMap;
+
+use crate::{
+
liurenjie1024 commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1365064528
##
crates/iceberg/src/avro/schema.rs:
##
@@ -203,8 +197,8 @@ impl SchemaVisitor for SchemaToAvroSchema {
PrimitiveType::Timestamp => AvroSchema::Tim
ZENOTME commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1364980016
##
crates/iceberg/src/avro/schema.rs:
##
@@ -162,7 +168,7 @@ impl SchemaVisitor for SchemaToAvroSchema {
let value_field = {
let mut fi
liurenjie1024 commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1364967043
##
crates/iceberg/src/avro/schema.rs:
##
@@ -144,7 +150,7 @@ impl SchemaVisitor for SchemaToAvroSchema {
// not string type.
let key_fi
ZENOTME commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1364930268
##
crates/iceberg/src/avro/schema.rs:
##
@@ -144,7 +150,7 @@ impl SchemaVisitor for SchemaToAvroSchema {
// not string type.
let key_field =
liurenjie1024 commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1364844632
##
crates/iceberg/src/spec/values.rs:
##
@@ -996,10 +1008,552 @@ mod timestamptz {
}
}
+mod serde {
+use std::collections::BTreeMap;
+
+use crate
ZENOTME commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1364843043
##
crates/iceberg/src/spec/values.rs:
##
@@ -996,10 +1008,552 @@ mod timestamptz {
}
}
+mod serde {
+use std::collections::BTreeMap;
+
+use crate::{
+
liurenjie1024 commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1364825386
##
crates/iceberg/src/spec/values.rs:
##
@@ -996,10 +1008,552 @@ mod timestamptz {
}
}
+mod serde {
+use std::collections::BTreeMap;
+
+use crate
ZENOTME commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1364796056
##
crates/iceberg/src/spec/values.rs:
##
@@ -996,10 +1008,552 @@ mod timestamptz {
}
}
+mod serde {
+use std::collections::BTreeMap;
+
+use crate::{
+
liurenjie1024 commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1364771184
##
crates/iceberg/src/avro/schema.rs:
##
@@ -162,7 +168,7 @@ impl SchemaVisitor for SchemaToAvroSchema {
let value_field = {
let
ZENOTME commented on PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#issuecomment-1768932760
cc @JanKaul @Fokko @Xuanwo @liurenjie1024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ZENOTME opened a new pull request, #82:
URL: https://github.com/apache/iceberg-rust/pull/82
This PR:
1. modify to store i128 for Value::Decimal
It make more easy to process Value::Decimal and avoid type consisent problem
if we use Decimal.
2. support support ser/deser of value
3
37 matches
Mail list logo
