ZENOTME commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1367767663
##########
crates/iceberg/src/spec/values.rs:
##########
@@ -620,6 +622,47 @@ impl Struct {
}
}
+/// An iterator that moves out of a struct.
+pub struct StructIntoIter {
+ null_bitmap: bitvec::boxed::IntoIter,
+ fields: std::vec::IntoIter<Literal>,
+ field_ids: std::vec::IntoIter<i32>,
+ field_names: std::vec::IntoIter<String>,
+}
+
+impl Iterator for StructIntoIter {
+ type Item = (i32, Option<Literal>, String);
Review Comment:
Should it be `(i32,Option<Literal>)`?🤔 Seems we still need to store field id
in `Struct`
##########
crates/iceberg/src/spec/values.rs:
##########
@@ -620,6 +622,47 @@ impl Struct {
}
}
+/// An iterator that moves out of a struct.
+pub struct StructIntoIter {
+ null_bitmap: bitvec::boxed::IntoIter,
+ fields: std::vec::IntoIter<Literal>,
+ field_ids: std::vec::IntoIter<i32>,
+ field_names: std::vec::IntoIter<String>,
+}
+
+impl Iterator for StructIntoIter {
+ type Item = (i32, Option<Literal>, String);
Review Comment:
Should it be `(i32,Option<Literal>)`?🤔 Seems we still need to store field id
in `Struct`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
