liurenjie1024 merged PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
Xuanwo commented on PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#issuecomment-2285912142
Thanks, this PR should happy to go!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
jdockerty commented on PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#issuecomment-2285869645
> I believe we need a new PR for this. Would you like to have a try?
@Xuanwo Sure :100:
That is for updating `iceberg-rust` to `0.49` so that I can use it here,
right?
Xuanwo commented on PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#issuecomment-2285845613
Hi, @jdockerty, opendal v0.49 has been released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
jdockerty commented on code in PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#discussion_r1711376787
##
.github/workflows/ci.yml:
##
@@ -113,7 +113,7 @@ jobs:
run: cargo test --no-fail-fast --all-targets --all-features --workspace
- name: Async-s
Xuanwo commented on PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#issuecomment-2277849379
The opendal release is about to start, I expect to finish in next monday.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
Xuanwo commented on code in PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#discussion_r1711383831
##
.github/workflows/ci.yml:
##
@@ -113,7 +113,7 @@ jobs:
run: cargo test --no-fail-fast --all-targets --all-features --workspace
- name: Async-std
jdockerty commented on code in PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#discussion_r1711376787
##
.github/workflows/ci.yml:
##
@@ -113,7 +113,7 @@ jobs:
run: cargo test --no-fail-fast --all-targets --all-features --workspace
- name: Async-s
jdockerty commented on code in PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#discussion_r1711376787
##
.github/workflows/ci.yml:
##
@@ -113,7 +113,7 @@ jobs:
run: cargo test --no-fail-fast --all-targets --all-features --workspace
- name: Async-s
jdockerty commented on code in PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#discussion_r1711376787
##
.github/workflows/ci.yml:
##
@@ -113,7 +113,7 @@ jobs:
run: cargo test --no-fail-fast --all-targets --all-features --workspace
- name: Async-s
Xuanwo commented on code in PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#discussion_r1707406595
##
crates/iceberg/Cargo.toml:
##
@@ -62,7 +63,8 @@ futures = { workspace = true }
itertools = { workspace = true }
murmur3 = { workspace = true }
once_cell = { wor
jdockerty commented on code in PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#discussion_r1707251064
##
crates/iceberg/Cargo.toml:
##
@@ -62,7 +63,8 @@ futures = { workspace = true }
itertools = { workspace = true }
murmur3 = { workspace = true }
once_cell = {
jdockerty commented on code in PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#discussion_r1704242728
##
crates/iceberg/tests/file_io_gcs_test.rs:
##
@@ -0,0 +1,103 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license ag
jdockerty commented on code in PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#discussion_r1703160577
##
crates/iceberg/tests/file_io_gcs_test.rs:
##
@@ -0,0 +1,103 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license ag
Xuanwo commented on code in PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#discussion_r1704397856
##
crates/iceberg/src/io/storage_gcs.rs:
##
@@ -0,0 +1,74 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements
jdockerty commented on code in PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#discussion_r1704242728
##
crates/iceberg/tests/file_io_gcs_test.rs:
##
@@ -0,0 +1,103 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license ag
jdockerty commented on code in PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#discussion_r1704236572
##
crates/iceberg/src/io/storage_gcs.rs:
##
@@ -0,0 +1,74 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreeme
jdockerty commented on code in PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#discussion_r1704228696
##
crates/iceberg/src/io/storage_gcs.rs:
##
@@ -0,0 +1,74 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreeme
Xuanwo commented on code in PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#discussion_r1704197839
##
crates/iceberg/tests/file_io_gcs_test.rs:
##
@@ -0,0 +1,103 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agree
Xuanwo commented on code in PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#discussion_r1704167334
##
crates/iceberg/src/io/storage_gcs.rs:
##
@@ -0,0 +1,74 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements
jdockerty commented on code in PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#discussion_r1704188779
##
crates/iceberg/tests/file_io_gcs_test.rs:
##
@@ -0,0 +1,103 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license ag
jdockerty commented on code in PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#discussion_r1704182016
##
crates/iceberg/src/io/storage.rs:
##
@@ -117,7 +125,24 @@ impl Storage {
))
}
}
-#[cfg(all(not(fe
jdockerty commented on code in PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#discussion_r1704151685
##
crates/iceberg/Cargo.toml:
##
@@ -29,12 +29,13 @@ license = { workspace = true }
keywords = ["iceberg"]
[features]
-default = ["storage-memory", "storage-fs
jdockerty commented on code in PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#discussion_r1704151685
##
crates/iceberg/Cargo.toml:
##
@@ -29,12 +29,13 @@ license = { workspace = true }
keywords = ["iceberg"]
[features]
-default = ["storage-memory", "storage-fs
liurenjie1024 commented on code in PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#discussion_r1704136142
##
crates/iceberg/src/io/storage.rs:
##
@@ -117,7 +125,24 @@ impl Storage {
))
}
}
-#[cfg(all(no
jdockerty commented on code in PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#discussion_r1703160577
##
crates/iceberg/tests/file_io_gcs_test.rs:
##
@@ -0,0 +1,103 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license ag
jdockerty opened a new pull request, #520:
URL: https://github.com/apache/iceberg-rust/pull/520
Helps towards https://github.com/apache/iceberg-rust/issues/408 and
https://github.com/apache/iceberg-rust/issues/410
Adds support for GCS as a storage backend.
--
This is an automat
27 matches
Mail list logo
