jdockerty commented on code in PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#discussion_r1704151685


##########
crates/iceberg/Cargo.toml:
##########
@@ -29,12 +29,13 @@ license = { workspace = true }
 keywords = ["iceberg"]
 
 [features]
-default = ["storage-memory", "storage-fs", "storage-s3", "tokio"]
-storage-all = ["storage-memory", "storage-fs", "storage-s3"]
+default = ["storage-memory", "storage-fs", "storage-s3", "tokio", 
"storage-gcs"]

Review Comment:
   Yeah absolutely, i should've mentioned this.
   
   I was going to ask whether we wanted to remove this prior to finishing up. 
That answers my question though, I'll remove this from being default before 
this gets merged 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to