jdockerty commented on code in PR #520:
URL: https://github.com/apache/iceberg-rust/pull/520#discussion_r1711376787
##########
.github/workflows/ci.yml:
##########
@@ -113,7 +113,7 @@ jobs:
run: cargo test --no-fail-fast --all-targets --all-features --workspace
- name: Async-std Test
- run: cargo test --no-fail-fast --all-targets --no-default-features
--features "async-std" --features "storage-fs" --workspace
+ run: cargo test --no-fail-fast --all-targets --no-default-features
--features "async-std" --features "storage-all" --workspace
Review Comment:
I'm not 100% certain this is the right approach, but I figured rather than
adding on another item for `storage-gcs`, simply using `storage-all` here
covers it for future contributors too.
Granted, I'm not quite sure whether this is what we want. Happy to
alter/take suggestions :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
