liurenjie1024 commented on code in PR #106:
URL: https://github.com/apache/iceberg-rust/pull/106#discussion_r1419858086
##
crates/iceberg/src/catalog/mod.rs:
##
@@ -758,23 +760,19 @@ mod tests {
{
"action": "add-spec",
"spec": {
-"spec-id": 1,
"fields
Fokko commented on PR #106:
URL: https://github.com/apache/iceberg-rust/pull/106#issuecomment-1845257956
Thanks @my-vegetable-has-exploded for working on this, and @liurenjie1024
and @Xuanwo for reviewing this 👍
--
This is an automated message from the Apache Git Service.
To respond to t
Fokko merged PR #106:
URL: https://github.com/apache/iceberg-rust/pull/106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
Fokko commented on code in PR #106:
URL: https://github.com/apache/iceberg-rust/pull/106#discussion_r141983
##
crates/iceberg/src/catalog/mod.rs:
##
@@ -758,23 +760,19 @@ mod tests {
{
"action": "add-spec",
"spec": {
-"spec-id": 1,
"fields": [
Fokko commented on code in PR #106:
URL: https://github.com/apache/iceberg-rust/pull/106#discussion_r1418823234
##
crates/iceberg/src/catalog/mod.rs:
##
@@ -758,23 +760,19 @@ mod tests {
{
"action": "add-spec",
"spec": {
-"spec-id": 1,
"fields": [
Fokko commented on code in PR #106:
URL: https://github.com/apache/iceberg-rust/pull/106#discussion_r1418824322
##
crates/iceberg/src/catalog/mod.rs:
##
@@ -758,23 +760,19 @@ mod tests {
{
"action": "add-spec",
"spec": {
-"spec-id": 1,
"fields": [
Fokko commented on code in PR #106:
URL: https://github.com/apache/iceberg-rust/pull/106#discussion_r1418820203
##
crates/iceberg/src/catalog/mod.rs:
##
@@ -758,23 +760,19 @@ mod tests {
{
"action": "add-spec",
"spec": {
-"spec-id": 1,
"fields": [
liurenjie1024 commented on code in PR #106:
URL: https://github.com/apache/iceberg-rust/pull/106#discussion_r1418814937
##
crates/iceberg/src/catalog/mod.rs:
##
@@ -758,23 +760,19 @@ mod tests {
{
"action": "add-spec",
"spec": {
-"spec-id": 1,
"fields
Fokko commented on code in PR #106:
URL: https://github.com/apache/iceberg-rust/pull/106#discussion_r1418802658
##
crates/iceberg/src/catalog/mod.rs:
##
@@ -758,23 +760,19 @@ mod tests {
{
"action": "add-spec",
"spec": {
-"spec-id": 1,
"fields": [
my-vegetable-has-exploded commented on code in PR #106:
URL: https://github.com/apache/iceberg-rust/pull/106#discussion_r1414825717
##
crates/iceberg/src/spec/partition.rs:
##
@@ -60,13 +60,51 @@ impl PartitionSpec {
}
}
+/// Reference to [`UnboundPartitionSpec`].
+pub t
Xuanwo commented on code in PR #106:
URL: https://github.com/apache/iceberg-rust/pull/106#discussion_r1414797588
##
crates/iceberg/src/spec/partition.rs:
##
@@ -60,13 +60,51 @@ impl PartitionSpec {
}
}
+/// Reference to [`UnboundPartitionSpec`].
+pub type UnboundPartitio
liurenjie1024 commented on PR #106:
URL: https://github.com/apache/iceberg-rust/pull/106#issuecomment-1839889064
cc @Fokko PTAL, I think this is ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
my-vegetable-has-exploded commented on code in PR #106:
URL: https://github.com/apache/iceberg-rust/pull/106#discussion_r1410103369
##
crates/iceberg/src/spec/partition.rs:
##
@@ -60,6 +60,44 @@ impl PartitionSpec {
}
}
+/// Reference to [`UnboundPartitionSpec`].
+pub ty
liurenjie1024 commented on code in PR #106:
URL: https://github.com/apache/iceberg-rust/pull/106#discussion_r1410088445
##
crates/iceberg/src/spec/partition.rs:
##
@@ -60,6 +60,44 @@ impl PartitionSpec {
}
}
+/// Reference to [`UnboundPartitionSpec`].
+pub type UnboundPa
my-vegetable-has-exploded commented on code in PR #106:
URL: https://github.com/apache/iceberg-rust/pull/106#discussion_r1410083813
##
crates/iceberg/src/spec/partition.rs:
##
@@ -60,6 +62,99 @@ impl PartitionSpec {
}
}
+static PARTITION_DATA_ID_START: i32 = 1000;
+
+///
my-vegetable-has-exploded commented on code in PR #106:
URL: https://github.com/apache/iceberg-rust/pull/106#discussion_r1410082084
##
crates/iceberg/src/spec/partition.rs:
##
@@ -60,6 +62,99 @@ impl PartitionSpec {
}
}
+static PARTITION_DATA_ID_START: i32 = 1000;
+
+///
liurenjie1024 commented on code in PR #106:
URL: https://github.com/apache/iceberg-rust/pull/106#discussion_r1405573783
##
crates/iceberg/src/error.rs:
##
@@ -33,6 +33,8 @@ pub enum ErrorKind {
/// service error.
Unexpected,
+/// Iceberg finds some conflict when
my-vegetable-has-exploded opened a new pull request, #106:
URL: https://github.com/apache/iceberg-rust/pull/106
close #98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
18 matches
Mail list logo
