Fokko commented on code in PR #106:
URL: https://github.com/apache/iceberg-rust/pull/106#discussion_r1418820203
##########
crates/iceberg/src/catalog/mod.rs:
##########
@@ -758,23 +760,19 @@ mod tests {
{
"action": "add-spec",
"spec": {
- "spec-id": 1,
"fields": [
{
"source-id": 4,
- "field-id": 1000,
Review Comment:
The open-api spec is a bit unclear, but it isn't right now:
https://github.com/apache/iceberg/blob/af9522ac7e8e25dc044622c566b66301b6df9581/open-api/rest-catalog-open-api.py#L283-L284
References:
https://github.com/apache/iceberg/blob/af9522ac7e8e25dc044622c566b66301b6df9581/open-api/rest-catalog-open-api.py#L138-L140
References:
https://github.com/apache/iceberg/blob/af9522ac7e8e25dc044622c566b66301b6df9581/open-api/rest-catalog-open-api.py#L131-L135
And there it is non-optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
