liurenjie1024 commented on code in PR #106:
URL: https://github.com/apache/iceberg-rust/pull/106#discussion_r1419858086
##########
crates/iceberg/src/catalog/mod.rs:
##########
@@ -758,23 +760,19 @@ mod tests {
{
"action": "add-spec",
"spec": {
- "spec-id": 1,
"fields": [
{
"source-id": 4,
- "field-id": 1000,
Review Comment:
Thanks for the reference, I saw the comments now. But I think in the rest
api request, it's reasonable to make it optional, and ask the server to assign
a meaningful field id to it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
