liurenjie1024 merged PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
liurenjie1024 commented on code in PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#discussion_r1968754297
##
crates/iceberg/src/spec/schema/visitor.rs:
##
@@ -121,3 +121,162 @@ pub fn visit_schema(schema: &Schema,
visitor: &mut V) -> Resul
let result = visit_
ZENOTME commented on code in PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#discussion_r1967364613
##
crates/iceberg/src/spec/schema.rs:
##
@@ -1146,6 +1146,170 @@ impl ReassignFieldIds {
}
}
+/// A post order schema visitor with partner.
+///
+/// For ord
ZENOTME commented on code in PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#discussion_r1967350077
##
crates/iceberg/src/spec/values.rs:
##
@@ -1564,6 +1564,16 @@ impl Literal {
Self::Primitive(PrimitiveLiteral::Long(value))
}
+/// Creates a ti
liurenjie1024 commented on code in PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#discussion_r1964807198
##
crates/iceberg/src/arrow/value.rs:
##
@@ -0,0 +1,1222 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agre
liurenjie1024 commented on code in PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#discussion_r1952367599
##
crates/iceberg/src/spec/schema.rs:
##
@@ -1132,6 +1132,213 @@ impl ReassignFieldIds {
}
}
+/// A post order schema visitor with partner.
+///
+/// F
ZENOTME commented on code in PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#discussion_r1949654188
##
crates/iceberg/src/arrow/value.rs:
##
@@ -0,0 +1,874 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
ZENOTME commented on PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#issuecomment-2648843125
> Thanks @ZENOTME for this pr. I have some concerns about the processing of
list/map
Hi @liurenjie1024, I find a way to avoid the iterator design. And for now,
our SchemaWithPar
ZENOTME commented on code in PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#discussion_r1948549782
##
crates/iceberg/src/spec/schema.rs:
##
@@ -1132,6 +1132,213 @@ impl ReassignFieldIds {
}
}
+/// A post order schema visitor with partner.
+///
+/// For ord
ZENOTME commented on code in PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#discussion_r1912050258
##
crates/iceberg/src/spec/schema.rs:
##
@@ -1132,6 +1132,213 @@ impl ReassignFieldIds {
}
}
+/// A post order schema visitor with partner.
+///
+/// For ord
ZENOTME commented on code in PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#discussion_r1899344509
##
crates/iceberg/src/spec/schema.rs:
##
@@ -1132,6 +1132,213 @@ impl ReassignFieldIds {
}
}
+/// A post order schema visitor with partner.
+///
+/// For ord
ZENOTME commented on code in PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#discussion_r1899344509
##
crates/iceberg/src/spec/schema.rs:
##
@@ -1132,6 +1132,213 @@ impl ReassignFieldIds {
}
}
+/// A post order schema visitor with partner.
+///
+/// For ord
ZENOTME commented on code in PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#discussion_r1899343049
##
crates/iceberg/src/spec/schema.rs:
##
@@ -1132,6 +1132,213 @@ impl ReassignFieldIds {
}
}
+/// A post order schema visitor with partner.
+///
+/// For ord
ZENOTME commented on code in PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#discussion_r1899342562
##
crates/iceberg/src/spec/schema.rs:
##
@@ -1132,6 +1132,213 @@ impl ReassignFieldIds {
}
}
+/// A post order schema visitor with partner.
+///
+/// For ord
ZENOTME commented on code in PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#discussion_r1899341695
##
crates/iceberg/src/spec/schema.rs:
##
@@ -1132,6 +1132,213 @@ impl ReassignFieldIds {
}
}
+/// A post order schema visitor with partner.
+///
+/// For ord
liurenjie1024 commented on code in PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#discussion_r1899291231
##
crates/iceberg/src/spec/schema.rs:
##
@@ -1132,6 +1132,213 @@ impl ReassignFieldIds {
}
}
+/// A post order schema visitor with partner.
+///
+/// F
ZENOTME commented on PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#issuecomment-2545020315
> Thanks @ZENOTME 's effort. I saw that both java/python have schema with
partner visitor:
>
> 1.
[SchemaWithPartnerVisitor](https://github.com/apache/iceberg/blob/c07f2aabc0a1d
liurenjie1024 commented on code in PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#discussion_r1886086140
##
crates/iceberg/src/arrow/value.rs:
##
@@ -0,0 +1,874 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agree
liurenjie1024 commented on code in PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#discussion_r1886072909
##
crates/iceberg/src/arrow/value.rs:
##
@@ -0,0 +1,1015 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agre
ZENOTME commented on code in PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#discussion_r1877408386
##
crates/iceberg/src/arrow/value.rs:
##
@@ -0,0 +1,874 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
Fokko commented on code in PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#discussion_r1872818669
##
crates/iceberg/src/arrow/value.rs:
##
@@ -0,0 +1,874 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
Fokko commented on code in PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#discussion_r1872790244
##
crates/iceberg/src/arrow/value.rs:
##
@@ -0,0 +1,874 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
Fokko commented on code in PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#discussion_r1872790244
##
crates/iceberg/src/arrow/value.rs:
##
@@ -0,0 +1,874 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
liurenjie1024 commented on code in PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#discussion_r1872521649
##
crates/iceberg/src/arrow/value.rs:
##
@@ -0,0 +1,874 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agree
ZENOTME commented on PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#issuecomment-2516429652
> Hi, @ZENOTME Thanks for this pr! I'm thinking that instead of array
transformation, should we consider transforming arrow record batch to/from
array of iceberg datum?
For now
liurenjie1024 commented on PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#issuecomment-2516049034
Hi, @ZENOTME Thanks for this pr! I'm thinking that instead of array
transformation, should we consider transforming arrow record batch to/from
array of iceberg datum? It maybe al
ZENOTME commented on PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#issuecomment-2506041190
cc @liurenjie1024 @Fokko @Xuanwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
ZENOTME opened a new pull request, #731:
URL: https://github.com/apache/iceberg-rust/pull/731
This PR introduces the function to convert arrow struct to iceberg struct.
This function is needed when we add fanout partition writer: In this writer, we
need to compute the partition value using
28 matches
Mail list logo
