ZENOTME commented on code in PR #731:
URL: https://github.com/apache/iceberg-rust/pull/731#discussion_r1967350077
##########
crates/iceberg/src/spec/values.rs:
##########
@@ -1564,6 +1564,16 @@ impl Literal {
Self::Primitive(PrimitiveLiteral::Long(value))
}
+ /// Creates a timestamp from unix epoch in nanoseconds.
+ pub fn timestamp_nano(value: i64) -> Self {
+ Self::Primitive(PrimitiveLiteral::Long(value))
+ }
+
+ /// Creates a timestamp with timezone from unix epoch in nanoseconds.
+ pub fn timestamptz_nano(value: i64) -> Self {
Review Comment:
How about another PR to refine them together?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
