ZENOTME commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1426129491
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -1120,15 +1236,17 @@ mod test {
#[tokio::test]
async fn test_manifest_list_writer_v2() {
-let ex
Fokko merged PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
ZENOTME commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1425139874
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -0,0 +1,1864 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements
Fokko commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1425137422
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -0,0 +1,1864 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
Fokko commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1425129671
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -0,0 +1,1821 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
Fokko commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1425117160
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -0,0 +1,1821 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
Fokko commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1425109506
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -1120,15 +1236,17 @@ mod test {
#[tokio::test]
async fn test_manifest_list_writer_v2() {
-let expe
ZENOTME commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1425067275
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -0,0 +1,1864 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements
Fokko commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1425045199
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -0,0 +1,1864 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
ZENOTME commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1424936927
##
crates/iceberg/src/spec/partition.rs:
##
@@ -69,6 +71,30 @@ impl PartitionSpec {
.iter()
.all(|f| matches!(f.transform, Transform:
liurenjie1024 commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1424930591
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -156,12 +171,36 @@ impl ManifestListWriter {
match self.format_version {
FormatVersion::
liurenjie1024 commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1424928716
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -156,12 +171,36 @@ impl ManifestListWriter {
match self.format_version {
FormatVersion::
liurenjie1024 commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1424926195
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -156,12 +171,36 @@ impl ManifestListWriter {
match self.format_version {
FormatVersion::
liurenjie1024 commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1424922090
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -156,12 +171,36 @@ impl ManifestListWriter {
match self.format_version {
FormatVersion::
ZENOTME commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1424919618
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -156,12 +171,36 @@ impl ManifestListWriter {
match self.format_version {
FormatVersion::V1 =>
ZENOTME commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1424917585
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -156,12 +171,36 @@ impl ManifestListWriter {
match self.format_version {
FormatVersion::V1 =>
liurenjie1024 commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1424912963
##
.typos.toml:
##
@@ -0,0 +1,2 @@
+[files]
+extend-exclude = ["crates/iceberg/testdata"]
Review Comment:
Is it possible to sth like `**/testdata`? I think a
liurenjie1024 commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1424901931
##
crates/iceberg/src/spec/partition.rs:
##
@@ -69,6 +71,30 @@ impl PartitionSpec {
.iter()
.all(|f| matches!(f.transform, Tran
ZENOTME commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1424859048
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -30,6 +30,9 @@ use self::{
use super::{FormatVersion, StructType};
+/// The seq number when no added files are
ZENOTME commented on PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#issuecomment-1853284225
> > I think we need to add configurations in `typos.toml` to skip the check:
> > https://github.com/crate-ci/typos/blob/master/docs/reference.md
>
> Yep, we should skip check on
Xuanwo commented on PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#issuecomment-1853251575
> I think we need to add configurations in `typos.toml` to skip the check:
>
> https://github.com/crate-ci/typos/blob/master/docs/reference.md
Yep, we should skip check on `te
ZENOTME commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1424780979
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -30,6 +30,9 @@ use self::{
use super::{FormatVersion, StructType};
+/// The seq number when no added files are
liurenjie1024 commented on PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#issuecomment-1851488380
I think we need to add configurations in `typos.toml` to skip the check:
https://github.com/crate-ci/typos/blob/master/docs/reference.md
--
This is an automated message fro
liurenjie1024 commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1423586207
##
crates/iceberg/src/spec/transform.rs:
##
@@ -126,17 +126,20 @@ pub enum Transform {
impl Transform {
/// Get the return type of transform given the inpu
ZENOTME commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1423585720
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -0,0 +1,1847 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements
liurenjie1024 commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1423579372
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -0,0 +1,1847 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agre
liurenjie1024 commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1423583040
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -30,6 +30,9 @@ use self::{
use super::{FormatVersion, StructType};
+/// The seq number when no added file
liurenjie1024 commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1423579372
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -0,0 +1,1847 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agre
Fokko commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1423535271
##
crates/iceberg/src/spec/transform.rs:
##
@@ -126,17 +126,20 @@ pub enum Transform {
impl Transform {
/// Get the return type of transform given the input type.
Fokko commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1423537034
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -0,0 +1,1847 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
Fokko commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1423535271
##
crates/iceberg/src/spec/transform.rs:
##
@@ -126,17 +126,20 @@ pub enum Transform {
impl Transform {
/// Get the return type of transform given the input type.
Fokko commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1423526180
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -30,6 +30,9 @@ use self::{
use super::{FormatVersion, StructType};
+/// The seq number when no added files are pr
liurenjie1024 commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1420028918
##
crates/iceberg/src/spec/transform.rs:
##
@@ -126,17 +126,20 @@ pub enum Transform {
impl Transform {
/// Get the return type of transform given the inpu
liurenjie1024 commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1420025262
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -30,6 +30,9 @@ use self::{
use super::{FormatVersion, StructType};
+/// The seq number when no added file
Xuanwo commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1419945979
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -0,0 +1,1847 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
ZENOTME commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1419902834
##
crates/iceberg/src/spec/transform.rs:
##
@@ -126,17 +126,20 @@ pub enum Transform {
impl Transform {
/// Get the return type of transform given the input type
ZENOTME commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1419901970
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -30,6 +30,9 @@ use self::{
use super::{FormatVersion, StructType};
+/// The seq number when no added files are
liurenjie1024 commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1413462308
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -30,6 +30,9 @@ use self::{
use super::{FormatVersion, StructType};
+/// The seq number when no added file
ZENOTME commented on PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#issuecomment-1834010470
Seem the binary file will make typos fail. Maybe we should fix #70 first.
Other parts is ready to review.
--
This is an automated message from the Apache Git Service.
To respond to the
ZENOTME commented on PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#issuecomment-1834001803
Sorry for being late. The #82 has closed. Let's move again. I have fixed the
problem mentioned above and recommit.
--
This is an automated message from the Apache Git Service.
To resp
ZENOTME commented on PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#issuecomment-1768931859
I have send a new PR #82 for value part. Let's complete it first and then
continue on working this PR later.
--
This is an automated message from the Apache Git Service.
To respond to
ZENOTME commented on PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#issuecomment-1768546364
I will split the RawLiteral out into another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Fokko commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1363824086
##
crates/iceberg/src/spec/values.rs:
##
@@ -966,6 +978,547 @@ mod timestamptz {
}
}
+mod serde {
+use std::collections::{BTreeMap, HashMap};
+
+use crat
Fokko commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1363761173
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -0,0 +1,671 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
Fokko commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1363758398
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -0,0 +1,671 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
Fokko commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1363751192
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -0,0 +1,671 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
Fokko commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1363750143
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -0,0 +1,671 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
Fokko commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1363748144
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -0,0 +1,671 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
ZENOTME commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1362079101
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -0,0 +1,671 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
JanKaul commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1362007623
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -0,0 +1,671 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
ZENOTME commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1360421087
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -0,0 +1,671 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
JanKaul commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1360224491
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -0,0 +1,671 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
JanKaul commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1360204175
##
crates/iceberg/src/spec/values.rs:
##
@@ -966,6 +978,547 @@ mod timestamptz {
}
}
+mod serde {
Review Comment:
I think using the RawLiteral makes sense.
liurenjie1024 commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1358133729
##
crates/iceberg/src/spec/values.rs:
##
@@ -966,6 +978,547 @@ mod timestamptz {
}
}
+mod serde {
Review Comment:
I'm ok with this approach, cc @JanK
ZENOTME commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1357921009
##
crates/iceberg/src/spec/partition.rs:
##
@@ -54,6 +56,24 @@ impl PartitionSpec {
pub fn builder() -> PartitionSpecBuilder {
PartitionSpecBuilder::defa
ZENOTME commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1357920808
##
crates/iceberg/src/spec/values.rs:
##
@@ -966,6 +978,547 @@ mod timestamptz {
}
}
+mod serde {
Review Comment:
If `RawLiteral` looks well, I can seperat
liurenjie1024 commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1357853771
##
crates/iceberg/src/spec/partition.rs:
##
@@ -54,6 +56,24 @@ impl PartitionSpec {
pub fn builder() -> PartitionSpecBuilder {
PartitionSpecBuilder
ZENOTME commented on PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#issuecomment-1760940516
For now, it still not been completed.
It only complete the basic design and I want to make sure whether the design
well first.
If it looks well, I will complete it and add
ZENOTME opened a new pull request, #79:
URL: https://github.com/apache/iceberg-rust/pull/79
This PR prepare to support read/write Manifest.
related issue: #36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
59 matches
Mail list logo
