ZENOTME commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1419901970
##########
crates/iceberg/src/spec/manifest_list.rs:
##########
@@ -30,6 +30,9 @@ use self::{
use super::{FormatVersion, StructType};
+/// The seq number when no added files are present.
+pub const UNASSIGNED_SEQ_NUMBER: i64 = -1;
Review Comment:
It's for
[min_sequence_number](https://iceberg.apache.org/spec/#manifests:~:text=516-,min_sequence_number,-long).
Which means that all manifest entry is deleted. Actually, I am not sure
whether it's the correct process way because there is not
`UNASSIGNED_SEQ_NUMBER` mentioned in spec.🤔 Does pyiceberg use
`UNASSIGNED_SEQ_NUMBER`? cc @Fokko
##########
crates/iceberg/src/spec/manifest_list.rs:
##########
@@ -30,6 +30,9 @@ use self::{
use super::{FormatVersion, StructType};
+/// The seq number when no added files are present.
+pub const UNASSIGNED_SEQ_NUMBER: i64 = -1;
Review Comment:
It's for
[min_sequence_number](https://iceberg.apache.org/spec/#manifests:~:text=516-,min_sequence_number,-long).
Which means that all manifest entry is deleted. Actually, I am not sure
whether it's the correct process way because there is not
`UNASSIGNED_SEQ_NUMBER` mentioned in spec.🤔 Does pyiceberg use
`UNASSIGNED_SEQ_NUMBER`? cc @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
