Re: [PR] feat: suport read/write Manifest [iceberg-rust]

[via GitHub]

ZENOTME commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1426129491


##########
crates/iceberg/src/spec/manifest_list.rs:
##########
@@ -1120,15 +1236,17 @@ mod test {
 
     #[tokio::test]
     async fn test_manifest_list_writer_v2() {
-        let expected_manifest_list = ManifestList {
+        let snapshot_id = 377075049360453639;
+        let seq_num = 1;
+        let mut expected_manifest_list = ManifestList {
             entries: vec![ManifestListEntry {
                 manifest_path: 
"s3a://icebergdata/demo/s1/t1/metadata/05ffe08b-810f-49b3-a8f4-e88fc99b254a-m0.avro".to_string(),
                 manifest_length: 6926,
                 partition_spec_id: 1,
                 content: ManifestContentType::Data,
-                sequence_number: 1,
-                min_sequence_number: 1,
-                added_snapshot_id: 377075049360453639,
+                sequence_number: UNASSIGNED_SEQUENCE_NUMBER,

Review Comment:
   I'm sorry. I'm not sure what you mean.🤔 In here the `snapshot id` is 
assigned. What's the snapshots generation?



##########
crates/iceberg/src/spec/manifest_list.rs:
##########
@@ -1120,15 +1236,17 @@ mod test {
 
     #[tokio::test]
     async fn test_manifest_list_writer_v2() {
-        let expected_manifest_list = ManifestList {
+        let snapshot_id = 377075049360453639;
+        let seq_num = 1;
+        let mut expected_manifest_list = ManifestList {
             entries: vec![ManifestListEntry {
                 manifest_path: 
"s3a://icebergdata/demo/s1/t1/metadata/05ffe08b-810f-49b3-a8f4-e88fc99b254a-m0.avro".to_string(),
                 manifest_length: 6926,
                 partition_spec_id: 1,
                 content: ManifestContentType::Data,
-                sequence_number: 1,
-                min_sequence_number: 1,
-                added_snapshot_id: 377075049360453639,
+                sequence_number: UNASSIGNED_SEQUENCE_NUMBER,

Review Comment:
   I'm sorry. I'm not sure what you mean.🤔 In here the `snapshot id` is 
assigned. What's the snapshots generation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org