Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-06 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2075436721 ## pyiceberg/table/__init__.py: ## @@ -1371,6 +1375,45 @@ def to_polars(self) -> pl.LazyFrame: return pl.scan_iceberg(self) +def delete_orph

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-06 Thread via GitHub
Fokko commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2074880885 ## pyiceberg/table/__init__.py: ## @@ -1371,6 +1375,45 @@ def to_polars(self) -> pl.LazyFrame: return pl.scan_iceberg(self) +def delete_orphaned_f

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-04 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072668166 ## pyiceberg/table/__init__.py: ## @@ -1371,6 +1376,28 @@ def to_polars(self) -> pl.LazyFrame: return pl.scan_iceberg(self) +def delete_orph

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-04 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072667388 ## pyiceberg/table/inspect.py: ## @@ -657,3 +665,62 @@ def all_manifests(self) -> "pa.Table": lambda args: self._generate_manifests_table(*args)

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-04 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072662780 ## pyiceberg/table/inspect.py: ## @@ -657,3 +665,62 @@ def all_manifests(self) -> "pa.Table": lambda args: self._generate_manifests_table(*args)

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-04 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072661982 ## pyiceberg/table/__init__.py: ## @@ -1371,6 +1376,28 @@ def to_polars(self) -> pl.LazyFrame: return pl.scan_iceberg(self) +def delete_orph

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-04 Thread via GitHub
jayceslesar commented on PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#issuecomment-2849311767 > a meta question, wydt of moving the orphan file function to its own file/namespace, similar to how to use `.inspect`. > > i like the idea of having all the table mainte

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-04 Thread via GitHub
jayceslesar commented on PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#issuecomment-2849311662 > orphaned_files I think that makes sense -- would https://github.com/apache/iceberg-python/pull/1880 end up there too? Also ideally there is a CLI that exposes al

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-03 Thread via GitHub
kevinjqliu commented on PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#issuecomment-2848894707 a meta question, wydt of moving the orphan file function to its own file/namespace, similar to how to use `.inspect`. i like the idea of having all the table maintenance

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-03 Thread via GitHub
kevinjqliu commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072493113 ## pyiceberg/table/__init__.py: ## @@ -1371,6 +1376,28 @@ def to_polars(self) -> pl.LazyFrame: return pl.scan_iceberg(self) +def delete_orpha

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-03 Thread via GitHub
kevinjqliu commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072491310 ## pyiceberg/table/__init__.py: ## @@ -1371,6 +1376,28 @@ def to_polars(self) -> pl.LazyFrame: return pl.scan_iceberg(self) +def delete_orpha

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-03 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072452077 ## pyiceberg/table/__init__.py: ## @@ -1371,6 +1375,45 @@ def to_polars(self) -> pl.LazyFrame: return pl.scan_iceberg(self) +def delete_orph

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-03 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072448127 ## pyiceberg/table/inspect.py: ## @@ -657,3 +665,37 @@ def all_manifests(self) -> "pa.Table": lambda args: self._generate_manifests_table(*args)

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-03 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072448127 ## pyiceberg/table/inspect.py: ## @@ -657,3 +665,37 @@ def all_manifests(self) -> "pa.Table": lambda args: self._generate_manifests_table(*args)

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-03 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072446025 ## pyiceberg/table/inspect.py: ## @@ -657,3 +665,37 @@ def all_manifests(self) -> "pa.Table": lambda args: self._generate_manifests_table(*args)

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-03 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072446025 ## pyiceberg/table/inspect.py: ## @@ -657,3 +665,37 @@ def all_manifests(self) -> "pa.Table": lambda args: self._generate_manifests_table(*args)

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-03 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072445679 ## pyiceberg/table/inspect.py: ## @@ -657,3 +665,37 @@ def all_manifests(self) -> "pa.Table": lambda args: self._generate_manifests_table(*args)

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-03 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072442519 ## pyiceberg/table/inspect.py: ## @@ -657,3 +665,37 @@ def all_manifests(self) -> "pa.Table": lambda args: self._generate_manifests_table(*args)

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-03 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072436797 ## pyiceberg/table/inspect.py: ## @@ -657,3 +665,37 @@ def all_manifests(self) -> "pa.Table": lambda args: self._generate_manifests_table(*args)

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-03 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072436539 ## pyiceberg/table/inspect.py: ## @@ -657,3 +665,37 @@ def all_manifests(self) -> "pa.Table": lambda args: self._generate_manifests_table(*args)

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-03 Thread via GitHub
smaheshwar-pltr commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072429901 ## pyiceberg/table/inspect.py: ## @@ -657,3 +665,37 @@ def all_manifests(self) -> "pa.Table": lambda args: self._generate_manifests_table(*a

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-02 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072189663 ## pyiceberg/table/__init__.py: ## @@ -1371,6 +1375,45 @@ def to_polars(self) -> pl.LazyFrame: return pl.scan_iceberg(self) +def delete_orph

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-02 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072162712 ## pyiceberg/table/__init__.py: ## @@ -1371,6 +1375,45 @@ def to_polars(self) -> pl.LazyFrame: return pl.scan_iceberg(self) +def delete_orph

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-02 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072162570 ## pyiceberg/table/inspect.py: ## @@ -645,10 +645,10 @@ def data_files(self, snapshot_id: Optional[int] = None) -> "pa.Table": def delete_files(self, s

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-02 Thread via GitHub
Fokko commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2071124751 ## pyiceberg/table/__init__.py: ## @@ -1371,6 +1375,45 @@ def to_polars(self) -> pl.LazyFrame: return pl.scan_iceberg(self) +def delete_orphaned_f

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-04-29 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2067548613 ## pyiceberg/table/__init__.py: ## @@ -1371,6 +1375,45 @@ def to_polars(self) -> pl.LazyFrame: return pl.scan_iceberg(self) +def delete_orph

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-04-29 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2067540543 ## pyiceberg/table/inspect.py: ## @@ -645,10 +645,10 @@ def data_files(self, snapshot_id: Optional[int] = None) -> "pa.Table": def delete_files(self, s

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-04-29 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2067532346 ## pyiceberg/table/__init__.py: ## @@ -1371,6 +1375,45 @@ def to_polars(self) -> pl.LazyFrame: return pl.scan_iceberg(self) +def delete_orph

[PR] feat: delete orphaned files [iceberg-python]

2025-04-29 Thread via GitHub
jayceslesar opened a new pull request, #1958: URL: https://github.com/apache/iceberg-python/pull/1958 Closes #1200 # Rationale for this change Ability to do more table maintenance from pyiceberg (iceberg-python?) # Are these changes tested? Added a test! # Are ther