jayceslesar commented on code in PR #1958:
URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2067540543
##########
pyiceberg/table/inspect.py:
##########
@@ -645,10 +645,10 @@ def data_files(self, snapshot_id: Optional[int] = None)
-> "pa.Table":
def delete_files(self, snapshot_id: Optional[int] = None) -> "pa.Table":
return self._files(snapshot_id, {DataFileContent.POSITION_DELETES,
DataFileContent.EQUALITY_DELETES})
- def all_manifests(self) -> "pa.Table":
+ def all_manifests(self, snapshots: Optional[list[Snapshot]] = None) ->
"pa.Table":
import pyarrow as pa
- snapshots = self.tbl.snapshots()
+ snapshots = snapshots or self.tbl.snapshots()
if not snapshots:
Review Comment:
Another case of me treating snapshots and snapshot_id's the same... happy to
enforce this being snapshot_id's instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
