Fokko commented on code in PR #1958:
URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2074880885
##########
pyiceberg/table/__init__.py:
##########
@@ -1371,6 +1375,45 @@ def to_polars(self) -> pl.LazyFrame:
return pl.scan_iceberg(self)
+ def delete_orphaned_files(self) -> None:
Review Comment:
This is also a table property:
https://iceberg.apache.org/docs/nightly/configuration/#table-behavior-properties
Would be great to add `history.expire.max-snapshot-age-ms` to this PR. We
have the [`TableProperties`
class](https://github.com/apache/iceberg-python/blob/cf95f323711d23e49c2682ef805f763c0e6252d1/pyiceberg/table/__init__.py#L165)
where we can add this and also the default value. We can add
`history.expire.min-snapshots-to-keep` in a subsequent PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
