Re: [PR] feat: Make OAuth token server configurable [iceberg-rust]

2024-03-26 Thread via GitHub
flyrain merged PR #305: URL: https://github.com/apache/iceberg-rust/pull/305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] feat: Make OAuth token server configurable [iceberg-rust]

2024-03-26 Thread via GitHub
whynick1 commented on code in PR #305: URL: https://github.com/apache/iceberg-rust/pull/305#discussion_r1539735723 ## crates/catalog/rest/src/catalog.rs: ## @@ -956,6 +964,39 @@ mod tests { ); } +#[tokio::test] +async fn test_oauth_with_auth_url() { +

Re: [PR] feat: Make OAuth token server configurable [iceberg-rust]

2024-03-26 Thread via GitHub
himadripal commented on code in PR #305: URL: https://github.com/apache/iceberg-rust/pull/305#discussion_r1539661982 ## crates/catalog/rest/src/catalog.rs: ## @@ -956,6 +964,39 @@ mod tests { ); } +#[tokio::test] +async fn test_oauth_with_auth_url() { +

Re: [PR] feat: Make OAuth token server configurable [iceberg-rust]

2024-03-26 Thread via GitHub
liurenjie1024 commented on PR #305: URL: https://github.com/apache/iceberg-rust/pull/305#issuecomment-2020040124 @whynick1 Would you mind resolve the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] feat: Make OAuth token server configurable [iceberg-rust]

2024-03-25 Thread via GitHub
whynick1 commented on PR #305: URL: https://github.com/apache/iceberg-rust/pull/305#issuecomment-2019452515 @flyrain @liurenjie1024 Please take a look. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] feat: Make OAuth token server configurable [iceberg-rust]

2024-03-25 Thread via GitHub
whynick1 commented on code in PR #305: URL: https://github.com/apache/iceberg-rust/pull/305#discussion_r1538627909 ## crates/catalog/rest/src/catalog.rs: ## @@ -956,6 +964,39 @@ mod tests { ); } +#[tokio::test] +async fn test_oauth_with_auth_url() { +

Re: [PR] feat: Make OAuth token server configurable [iceberg-rust]

2024-03-25 Thread via GitHub
whynick1 commented on code in PR #305: URL: https://github.com/apache/iceberg-rust/pull/305#discussion_r1538627197 ## crates/catalog/rest/src/catalog.rs: ## @@ -866,8 +870,12 @@ mod tests { } async fn create_oauth_mock(server: &mut ServerGuard) -> Mock { +cre