whynick1 commented on code in PR #305:
URL: https://github.com/apache/iceberg-rust/pull/305#discussion_r1538627909


##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -956,6 +964,39 @@ mod tests {
         );
     }
 
+    #[tokio::test]
+    async fn test_oauth_with_auth_url() {
+        let mut server = Server::new_async().await;
+        let config_mock = create_config_mock(&mut server).await;
+
+        let mut auth_server = Server::new_async().await;
+        let auth_server_path = "/some/path";
+        let oauth_mock = create_oauth_mock_with_path(&mut auth_server, 
auth_server_path).await;

Review Comment:
   To explain the unit test, we first create a mock response for our OAuth 
Server. Then in line 978 - 981, set `rest.authorization-url` to use the OAuth 
Server (instead of default server). Finally, we verify the token is correct 
returned from our OAuth Server.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to