whynick1 commented on code in PR #305: URL: https://github.com/apache/iceberg-rust/pull/305#discussion_r1539735723
########## crates/catalog/rest/src/catalog.rs: ########## @@ -956,6 +964,39 @@ mod tests { ); } + #[tokio::test] + async fn test_oauth_with_auth_url() { + let mut server = Server::new_async().await; + let config_mock = create_config_mock(&mut server).await; + + let mut auth_server = Server::new_async().await; + let auth_server_path = "/some/path"; + let oauth_mock = create_oauth_mock_with_path(&mut auth_server, auth_server_path).await; Review Comment: No, because we already assert `rest.authorization-url` implicitly. If `rest.authorization-url` is not honored, we won't be able to get `token` from the mocked OAuth server (using same url) 🙂. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org