Re: [PR] feat(datafusion): support metadata tables for Datafusion [iceberg-rust]

2025-01-09 Thread via GitHub
liurenjie1024 closed pull request #879: feat(datafusion): support metadata tables for Datafusion URL: https://github.com/apache/iceberg-rust/pull/879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] feat(datafusion): support metadata tables for Datafusion [iceberg-rust]

2025-01-09 Thread via GitHub
liurenjie1024 commented on PR #879: URL: https://github.com/apache/iceberg-rust/pull/879#issuecomment-2579718303 Thanks @xxchan for contributing. I'll start reviewing after we addressed #868 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] feat(datafusion): support metadata tables for Datafusion [iceberg-rust]

2025-01-09 Thread via GitHub
liurenjie1024 commented on PR #879: URL: https://github.com/apache/iceberg-rust/pull/879#issuecomment-2579719266 Sorry, closed by mistake. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] feat(datafusion): support metadata tables for Datafusion [iceberg-rust]

2025-01-08 Thread via GitHub
xxchan commented on code in PR #879: URL: https://github.com/apache/iceberg-rust/pull/879#discussion_r1907342718 ## crates/integrations/datafusion/src/table/metadata_table.rs: ## @@ -0,0 +1,95 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribu

Re: [PR] feat(datafusion): support metadata tables for Datafusion [iceberg-rust]

2025-01-05 Thread via GitHub
xxchan commented on PR #879: URL: https://github.com/apache/iceberg-rust/pull/879#issuecomment-2572114662 cc @liurenjie1024 @Xuanwo @rshkv @flaneur2020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] feat(datafusion): support metadata tables for Datafusion [iceberg-rust]

2025-01-05 Thread via GitHub
xxchan commented on code in PR #879: URL: https://github.com/apache/iceberg-rust/pull/879#discussion_r1903316029 ## crates/integrations/datafusion/tests/integration_datafusion_test.rs: ## @@ -295,3 +303,129 @@ async fn test_table_predict_pushdown() -> Result<()> { assert!(s

Re: [PR] feat(datafusion): support metadata tables for Datafusion [iceberg-rust]

2025-01-05 Thread via GitHub
xxchan commented on code in PR #879: URL: https://github.com/apache/iceberg-rust/pull/879#discussion_r1903315532 ## crates/integrations/datafusion/src/schema.rs: ## @@ -89,14 +87,43 @@ impl SchemaProvider for IcebergSchemaProvider { } fn table_names(&self) -> Vec { -

Re: [PR] feat(datafusion): support metadata tables for Datafusion [iceberg-rust]

2025-01-05 Thread via GitHub
xxchan commented on code in PR #879: URL: https://github.com/apache/iceberg-rust/pull/879#discussion_r1903315532 ## crates/integrations/datafusion/src/schema.rs: ## @@ -89,14 +87,43 @@ impl SchemaProvider for IcebergSchemaProvider { } fn table_names(&self) -> Vec { -

[PR] feat(datafusion): support metadata tables for Datafusion [iceberg-rust]

2025-01-05 Thread via GitHub
xxchan opened a new pull request, #879: URL: https://github.com/apache/iceberg-rust/pull/879 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-